Skip to content

Monitor intermediate LST track collections at HLT #47437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Feb 25, 2025
Merged

Monitor intermediate LST track collections at HLT #47437

cmsbuild merged 1 commit into from
Feb 25, 2025

Conversation

@VourMa
Copy link
Contributor

@VourMa VourMa commented Feb 24, 2025

PR description:

Because the new LST track collections that run at HLT do not have the same names as the ones in the default configuration, they are actually not monitored. This PR introduces the relevant configuration changes that enables the monitoring of those collections.

The relevant track collections are retained in the EventContent. This doesn't have any effect on the default workflows, as the LST collections do not get produced there, while it recovers the lost collections in the LST workflows (i.e. no redundant info is retained in any case). At the validation step, the addition of the trackingLST and/or seedingLST procModifiers is necessary to show the proper extra columns with the plotting script.

This PR follows up on #46828 (comment) and works toward #39362 for LST.

PR validation:

The code has been tested with CMSSW_15_0_0_pre3 and the resulting plots can be found here.

Instructions on how to run 
runTheMatrix.py -w upgrade -l 29634.755 # For testing the trackingLST config
# For testing the seedingLST config, add the seedingLST procModifier in the step2 of the workflow above

cmsDriver.py DQM -s VALIDATION:hltMultiTrackValidation \
--conditions auto:phase2_realistic_T33 \
--geometry ExtendedRun4D110 \
--era Phase2C17I13M9 \
--datatier DQMIO \
--eventcontent DQM \
--filein file:step2.root \
--fileout DQM.root \
-n 10 --procModifiers alpaka,trackingLST # Add seedingLST if testing that config

cmsDriver.py HARVEST -s HARVESTING:@trackingOnlyValidation+@trackingOnlyDQM+postProcessorHLTtrackingSequence \
--filein file:DQM.root \
--scenario pp \
--filetype DQM \
--conditions auto:phase2_realistic_T33 \
--mc -n 100

mv DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root configName.root
makeTrackValidationPlots.py configName.root -o configName

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Feb 24, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47437/43850

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • DQMOffline/Trigger (dqm)
  • Validation/RecoTrack (dqm)

@antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @cericeci, @dgulhan, @fabiocos, @felicepantaleo, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @rovere, @trocino, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2025 •
edited
Loading

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 29634.704,29834.704
  • workflows = 29634.703,29834.703,29634.755,29834.755
  • relvals_opt = -w upgrade,standard
  • relvals_opt_gpu = -w upgrade,standard

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2025

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2025

@cmsbuild please abort test

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2025

@cmsbuild please test

hopefully parameters edited in place to add .755 workflows (not as a new post) will be picked up

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025

-1

Failed Tests: UnitTests RelVals RelVals-GPU RelVals-INPUT
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a5b8a/44623/summary.html
COMMIT: ff0b53b
CMSSW: CMSSW_15_1_X_2025-02-24-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47437/44623/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 5 errors in the following unit tests:

---> test TestConfigDP_7 had ERRORS
---> test TestConfigDP_8 had ERRORS
---> test TestConfigDP_12 had ERRORS
and more ...

RelVals

  • 1306.01306.0_SingleMuPt1_UP15/step3_SingleMuPt1_UP15.log
  • 29834.70329834.703_TTbar_14TeV+Run4D110PU_lstOnCPUIters01TrackingOnly/step3_TTbar_14TeV+Run4D110PU_lstOnCPUIters01TrackingOnly.log
  • 29700.029700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D110/step3_CloseByPGun_CE_H_Coarse_Scint+Run4D110.log
Expand to see more relval errors ...

RelVals-GPU

  • 12834.42312834.423_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation/step3_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation.log
  • 12834.42212834.422_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation/step3_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation.log
  • 12834.40612834.406_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka/step3_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka.log
Expand to see more relval errors ...

RelVals-INPUT

  • 2500.2322500.232_EGMNANOdata140Xrun3/step2_EGMNANOdata140Xrun3.log
  • 138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
  • 134.0134.0_MinimumBiasBS/step2_MinimumBiasBS.log
Expand to see more relval errors ...

mmusich
mmusich reviewed Feb 25, 2025
View reviewed changes
DQMOffline/Trigger/python/TrackingMonitoring_cff.py Outdated

from Configuration.ProcessModifiers.trackingLST_cff import trackingLST
from Configuration.ProcessModifiers.seedingLST_cff import seedingLST
(~seedingLST & trackingLST).toReplaceWith(trackingMonitorHLT, cms.Sequence(pixelTracksMonitoringHLT + iterHLTTracksMonitoringHLT + initialSteppTTCLSTTracksMonitoringHLT + initialSteppLSTCLSTTracksMonitoringHLT + initialStepT5TCLSTTracksMonitoringHLT + highPtTripletStepTracksMonitoringHLT))
Copy link
Contributor

@mmusich mmusich Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(~seedingLST & trackingLST).toReplaceWith(trackingMonitorHLT, cms.Sequence(pixelTracksMonitoringHLT + iterHLTTracksMonitoringHLT + initialSteppTTCLSTTracksMonitoringHLT + initialSteppLSTCLSTTracksMonitoringHLT + initialStepT5TCLSTTracksMonitoringHLT + highPtTripletStepTracksMonitoringHLT))
(~seedingLST & trackingLST).toReplaceWith(trackingMonitorHLT, cms.Sequence(pixelTracksMonitoringHLT + iterHLTTracksMonitoringHLT + initialSteppTTCLSTTracksMonitoringHLT + initialSteppLSTCLSTTracksMonitoringHLT + initialStepT5TCLSTTracksMonitoringHLT + iterHighPtTripletsMonitoringHLT))

?

Copy link
Contributor Author

@VourMa VourMa Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I must have mixed it up in the previous rebase, when I was fixing something else. It should be fixed now.

@VourMa VourMa force-pushed the CMSSW_15_0_0_pre3_wfsAndFuncs branch from ff0b53b to 0583db9 Compare February 25, 2025 09:34
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47437/43852

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025

Pull request #47437 was updated. @antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a5b8a/44626/summary.html
COMMIT: 0583db9
CMSSW: CMSSW_15_1_X_2025-02-24-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47437/44626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 581 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4212708
  • DQMHistoTests: Total failures: 2835
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4209853
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 234 log files, 204 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 157 differences found in the comparisons
  • DQMHistoTests: Total files compared: 9
  • DQMHistoTests: Total histograms compared: 117389
  • DQMHistoTests: Total failures: 2429
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 114960
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
  • Checked 32 log files, 36 edm output root files, 9 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

antoniovagnerini commented Feb 25, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Feb 25, 2025

+1

@cmsbuild cmsbuild merged commit b1b2374 into cms-sw:master Feb 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmusich mmusich mmusich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-checks-approved dqm-approved fully-signed operations-approved orp-approved tests-approved tracking

Projects

None yet

Milestone

CMSSW_15_1_X

Development

Successfully merging this pull request may close these issues.

6 participants

@VourMa @cmsbuild @slava77 @mmusich @antoniovagnerini @mandrenguyen