Skip to content

DQMStreamerReader: re-throw all exceptions when run in unit test mode #47430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Feb 25, 2025
Merged

DQMStreamerReader: re-throw all exceptions when run in unit test mode #47430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion DQMServices/StreamerIO/plugins/DQMStreamerReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ namespace dqmservices {
if (unitTest_) {
throw edm::Exception(edm::errors::FileReadError, "DQMStreamerReader::openNextFileInp")
<< std::string("Can't deserialize registry data (in open file): ") + e.what()
<< "\n error: data file corrupted";
<< "\n error: data file corrupted, rethrowing!";
}

fiterator_.logFileAction(std::string("Can't deserialize registry data (in open file): ") + e.what(), p);
Expand Down Expand Up @@ -354,6 +354,12 @@ namespace dqmservices {

deserializeEvent(*eview);
} catch (const cms::Exception& e) {
if (unitTest_) {
throw edm::Exception(edm::errors::FileReadError, "DQMStreamerReader::checkNext")
<< std::string("Can't deserialize event or registry data: ") + e.what()
<< "\n error: data file corrupted, rethrowing!";
}

// try to recover from corrupted files/events
fiterator_.logFileAction(std::string("Can't deserialize event or registry data: ") + e.what());
closeFileImp_("data file corrupted");
Expand Down Expand Up @@ -435,6 +441,11 @@ namespace dqmservices {
}
}
} catch (const cms::Exception& e) {
if (unitTest_) {
throw edm::Exception(edm::errors::FileReadError, "DQMStreamerReader::skip")
<< std::string("Can't deserialize registry data: ") + e.what()
<< "\n error: data file corrupted, rethrowing!";
}
// try to recover from corrupted files/events
fiterator_.logFileAction(std::string("Can't deserialize event data: ") + e.what());
closeFileImp_("data file corrupted");
Expand Down