Skip to content

Conversation

@missirol
Copy link
Contributor

backport of #47346

PR description:

From the description of #47346:

This PR adds ROOT dictionaries for std::pair<short,int> and (nested) vectors of that data type. This is motivated by the fact that a vector of CombinationsWithBxInCond (which is equal to std::pair<short,int> ) is a data member of the GlobalObjectMap class (which in turn is used in GlobalObjectMapRecord, one of the data formats used in the RAW data tier).

std::vector<CombinationsWithBxInCond> m_combinationWithBxVector;

The creation of these dictionaries was missed in #47030, and it likely led to the problem described in #47287.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#47346

Fixes a bug introduced in CMSSW_15_0_0_pre2 via #47030.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2025

A new Pull Request was created by @missirol for CMSSW_15_0_X.

It involves the following packages:

  • DataFormats/StdDictionaries (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2025

cms-bot internal usage

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23dedb/44385/summary.html
COMMIT: ec9225b
CMSSW: CMSSW_15_0_X_2025-02-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47347/44385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

Comparison differences are related to #39803 and #47071

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f71cd74 into cms-sw:CMSSW_15_0_X Feb 17, 2025
20 checks passed
@missirol missirol deleted the devel_addL1TCondDict branch February 17, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants