Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Feb 6, 2025

PR description:

These members did not exist in version 3. For more explanation see cms-sw/cmsdist#9643 (comment)

Resolves cms-sw/framework-team#1217

PR validation:

None

These members did not exist in version 3.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/CTPPSReco (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabferro, @grzanka, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Feb 6, 2025

@cmsbuild, please test

@pcanal
Copy link
Contributor

pcanal commented Feb 6, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d60ed/44238/summary.html
COMMIT: a7f9e64
CMSSW: CMSSW_15_0_X_2025-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47284/44238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 87
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016853
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = PhysicsTools/PatAlgos

@smuzaffar
Copy link
Contributor

please test

lets run unit test of PhysicsTools/PatAlgos which was failing in root's cmsdist PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d60ed/44248/summary.html
COMMIT: a7f9e64
CMSSW: CMSSW_15_0_X_2025-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47284/44248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild cmsbuild removed this from the CMSSW_15_0_X milestone Feb 7, 2025
@cmsbuild cmsbuild modified the milestones: CMSSW_15_1_X, CMSSW_15_0_X Feb 7, 2025
@jfernan2
Copy link
Contributor

jfernan2 commented Feb 7, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f251a1c into cms-sw:master Feb 8, 2025
12 checks passed
@makortel makortel deleted the patch-8 branch February 10, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix read rules for CTPPSLocalTrackLite

6 participants