Skip to content

Conversation

@artlbv
Copy link
Contributor

@artlbv artlbv commented Feb 6, 2025

PR description:

This is a follow up to #46489 updating the documentation in the readme of the P2GT plugin and the menu configuration.
These commits somehow got lost when squashing for the PR, hence apologies for the noise.

NB! the L1Trigger/Phase2L1GT/test/test_GT.py config is actually outdated, so did not even work with the previous menu. @HaarigerHarald @qvyz

PR validation:

Not needed, markdown only.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/Phase2L1GT (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025
@artlbv
Copy link
Contributor Author

artlbv commented Feb 12, 2025

Given the milestone moved to 15_0_1 I will do a backport to 15_0 once this is merged – this is essential documentation requested by the P2GT and needed for HLT.

@aloeliger @Moanwar could you review and merge this soon?

@Moanwar
Copy link
Contributor

Moanwar commented Feb 12, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61308d/44350/summary.html
COMMIT: b16e670
CMSSW: CMSSW_15_1_X_2025-02-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47282/44350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Moanwar
Copy link
Contributor

Moanwar commented Feb 12, 2025

+Upgrade

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fae8592 into cms-sw:master Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants