Add missing methods to Style class #47202

iarspider · 2025-01-29T15:53:19Z

PR description:

Fixes compilation errors with new ROOTMaster.

PR validation:

Bot tests

cmsbuild · 2025-01-29T15:53:45Z

cms-bot internal usage

cmsbuild · 2025-01-29T15:54:51Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43471

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43471/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43471/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-01-29T16:02:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43472

cmsbuild · 2025-01-29T16:02:37Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Validation/RecoParticleFlow (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@hatakeyamak, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2025-01-29T16:04:23Z

please test

makortel · 2025-01-29T16:39:46Z

Validation/RecoParticleFlow/interface/NicePlot.h

-class Style : public TH1 {};
+class Style : public TH1 {
+private:
+  void AddBinContent(Int_t){};


How come our clang-tidy doesn't change these to

Suggested change

void AddBinContent(Int_t){};

void AddBinContent(Int_t) override {};

?

good catch @makortel . We pass -header-filter='/build/muz/xx/CMSSW_15_0_CLANG_X_2025-01-28-2300/src/.*' to clang-tidy. Looks like it is not working any more [a] but using -header-filter='src/.*' works [b]. I will update the build rules to use relative path

[a]

> clang-tidy -export-fixes tmp/el8_amd64_gcc12/code-checks/Validation/RecoParticleFlow/src/NicePlot.cc.yaml -header-filter='/build/muz/xx/CMSSW_15_0_X_2025-01-29-1100/src/.*' src/Validation/RecoParticleFlow/src/NicePlot.cc 375 warnings generated. Suppressed 375 warnings (375 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

[b]

> clang-tidy -export-fixes tmp/el8_amd64_gcc12/code-checks/Validation/RecoParticleFlow/src/NicePlot.cc.yaml --header-filter='src/.*' src/Validation/RecoParticleFlow/src/NicePlot.cc 375 warnings generated. src/Validation/RecoParticleFlow/interface/NicePlot.h:9:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override] 9 | void AddBinContent(Int_t){}; | ^ | override src/Validation/RecoParticleFlow/interface/NicePlot.h:10:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override] 10 | void AddBinContent(Int_t, Double_t){}; | ^ | override src/Validation/RecoParticleFlow/interface/NicePlot.h:11:12: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override] 11 | Double_t RetrieveBinContent(Int_t) const { return 0.; }; | ^ | override src/Validation/RecoParticleFlow/interface/NicePlot.h:12:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override] 12 | void UpdateBinContent(Int_t, Double_t){}; | ^ | override

cmsbuild · 2025-01-29T18:08:19Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36cc03/44034/summary.html
COMMIT: 62296c6
CMSSW: CMSSW_15_0_X_2025-01-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47202/44034/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016770
DQMHistoTests: Total failures: 54
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016696
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-01-30T10:43:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43484

cmsbuild · 2025-01-30T10:43:23Z

Pull request #47202 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

iarspider · 2025-01-30T10:44:26Z

please test

cmsbuild · 2025-01-30T12:50:02Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36cc03/44068/summary.html
COMMIT: 0732ed7
CMSSW: CMSSW_15_0_X_2025-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47202/44068/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016770
DQMHistoTests: Total failures: 64
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016686
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2025-01-30T14:47:21Z

+dqm

spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )
spurious differences seen in TrackerPhase2OTL1Track (open issue Non-reproducibility in TrackerPhase2OTL1Track #47071)

cmsbuild · 2025-01-30T14:47:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2025-01-30T14:54:38Z

code-checks

cmsbuild · 2025-01-30T14:57:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47202/43490

mandrenguyen · 2025-01-30T15:50:28Z

+1

iarspider mentioned this pull request Jan 29, 2025

[ROOTMaster] Updated root to tip of branch master cms-sw/cmsdist#9643

Closed

cmsbuild added this to the CMSSW_15_0_X milestone Jan 29, 2025

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 29, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 29, 2025

iarspider force-pushed the fix-niceplot branch from 6f32bd3 to 62296c6 Compare January 29, 2025 16:00

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 29, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 29, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2025

makortel reviewed Jan 29, 2025

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jan 29, 2025

iarspider force-pushed the fix-niceplot branch from 62296c6 to 0bc8fc9 Compare January 30, 2025 09:17

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jan 30, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2025

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 30, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 30, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2025

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2025

cmsbuild merged commit 14fd2e0 into cms-sw:master Jan 30, 2025
11 checks passed

This was referenced Jan 30, 2025

Update pybind11 and apply array out of bound patch cms-sw/cmsdist#9654

Merged

Remove unused source member from an iorule in DataFormats/TauReco/src/classes_def_2.xml #47214

Merged

Sources now have independent ProductRegistry #47213

Merged

iarspider deleted the fix-niceplot branch January 31, 2025 09:13

	void AddBinContent(Int_t){};
	void AddBinContent(Int_t) override {};

Add missing methods to Style class #47202

Add missing methods to Style class #47202

Uh oh!

Conversation

iarspider commented Jan 29, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 29, 2025

Uh oh!

cmsbuild commented Jan 29, 2025

Uh oh!

cmsbuild commented Jan 29, 2025

Uh oh!

iarspider commented Jan 29, 2025

Uh oh!

makortel Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

smuzaffar Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 29, 2025

Comparison Summary

Uh oh!

cmsbuild commented Jan 30, 2025

Uh oh!

cmsbuild commented Jan 30, 2025

Uh oh!

iarspider commented Jan 30, 2025

Uh oh!

cmsbuild commented Jan 30, 2025

Comparison Summary

Uh oh!

antoniovagnerini commented Jan 30, 2025

Uh oh!

cmsbuild commented Jan 30, 2025

Uh oh!

smuzaffar commented Jan 30, 2025

Uh oh!

cmsbuild commented Jan 30, 2025

Uh oh!

mandrenguyen commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Jan 29, 2025 •

edited

Loading