Skip to content

Conversation

@missirol
Copy link
Contributor

@missirol missirol commented Jan 20, 2025

PR description:

This PR updates the unit test on the backward-compatibility of the data formats in DataFormats/L1TGlobal, extending it using inputs produced with CMSSW_15_0_0_pre2, given the data-format change introduced in #47030.

In addition, a cmd-line argument is added to create_GlobalObjectMapRecord_test_file_cfg.py to specify the "split level" of the output file (just for convenience when producing future unit-test input files).

This PR requires cms-data/DataFormats-L1TGlobal#3.

PR validation:

The relevant unit test passes.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • DataFormats/L1TGlobal (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test with cms-data/DataFormats-L1TGlobal#3

@makortel
Copy link
Contributor

Visually looks good to me (thanks @missirol!)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-059e90/43888/summary.html
COMMIT: 588d545
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47146/43888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818958
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

@cms-sw/l1-l2

This PR is needed for 15_0_X (if it misses 15_0_0_pre3 it would have to be backported to 15_0_X). Could you please have a look ? Thanks !

(reminder: this PR requires cms-data/DataFormats-L1TGlobal#3)

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DataFormats-L1TGlobal#3

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7f549d8 into cms-sw:master Jan 29, 2025
11 checks passed
@missirol missirol deleted the devel_DataFormatsL1TGlobal_bkwdCompTest_15_0_0_pre2 branch January 29, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants