-
Notifications
You must be signed in to change notification settings - Fork 4.6k
update TestGlobalObjectMapRecordFormat unit test with CMSSW_15_0_0_pre2 inputs
#47146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TestGlobalObjectMapRecordFormat unit test with CMSSW_15_0_0_pre2 inputs
#47146
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47146/43373 |
|
A new Pull Request was created by @missirol for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test with cms-data/DataFormats-L1TGlobal#3 |
|
Visually looks good to me (thanks @missirol!) |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
@cms-sw/l1-l2 This PR is needed for 15_0_X (if it misses 15_0_0_pre3 it would have to be backported to 15_0_X). Could you please have a look ? Thanks ! (reminder: this PR requires cms-data/DataFormats-L1TGlobal#3) |
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR updates the unit test on the backward-compatibility of the data formats in
DataFormats/L1TGlobal, extending it using inputs produced withCMSSW_15_0_0_pre2, given the data-format change introduced in #47030.In addition, a cmd-line argument is added to
create_GlobalObjectMapRecord_test_file_cfg.pyto specify the "split level" of the output file (just for convenience when producing future unit-test input files).This PR requires cms-data/DataFormats-L1TGlobal#3.
PR validation:
The relevant unit test passes.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A