Skip to content

Conversation

@AdrianoDee
Copy link
Contributor

PR description:

Updating the default datasets for 2022 (was 2021) conditions. Prompted by #46649 (comment).

PR validation:

Checking runTheMatrix.py -w upgrade -l 11834.0 --dryRun without this PR:

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py TTbar_14TeV_TuneCP5_cfi  -s GEN,SIM -n 10 --conditions auto:phase1_2022_realistic --beamspot DBrealistic --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3 --relval 9000,100 --fileout file:step1.root  > step1_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step2  -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2022 --conditions auto:phase1_2022_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein  file:step1.root  --fileout file:step2.root  > step2_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step3  -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidationNoHLT+@miniAODValidation,DQM:@standardDQMFakeHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2022_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein  file:step2.root  --fileout file:step3.root  > step3_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step4  -s HARVESTING:@standardValidationNoHLT+@standardDQMFakeHLT+@miniAODValidation+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2022_realistic --mc  --geometry DB:Extended --scenario pp --filetype DQM --era Run3 -n 10 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein file:step3_inDQM.root --fileout file:step4.root  > step4_TTbar_14TeV+2022PU.log  2>&1
 
11834.0_TTbar_14TeV+2022PU Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Mon Nov 25 12:41:20 2024-date Mon Nov 25 12:41:20 2024; exit: 0 0 0 0

With this PR:

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py TTbar_14TeV_TuneCP5_cfi  -s GEN,SIM -n 10 --conditions auto:phase1_2022_realistic --beamspot DBrealistic --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3 --relval 9000,100 --fileout file:step1.root  > step1_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step2  -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2022 --conditions auto:phase1_2022_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_13_1_0_pre1-130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v2_RV186-v1/GEN-SIM --filein  file:step1.root  --fileout file:step2.root  > step2_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step3  -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidationNoHLT+@miniAODValidation,DQM:@standardDQMFakeHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2022_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_13_1_0_pre1-130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v2_RV186-v1/GEN-SIM --filein  file:step2.root  --fileout file:step3.root  > step3_TTbar_14TeV+2022PU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_Fix2021/cmssw/src dryRun for 'cd 11834.0_TTbar_14TeV+2022PU
 cmsDriver.py step4  -s HARVESTING:@standardValidationNoHLT+@standardDQMFakeHLT+@miniAODValidation+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2022_realistic --mc  --geometry DB:Extended --scenario pp --filetype DQM --era Run3 -n 10 --pileup AVE_35_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_13_1_0_pre1-130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v2_RV186-v1/GEN-SIM --filein file:step3_inDQM.root --fileout file:step4.root  > step4_TTbar_14TeV+2022PU.log  2>&1
 
11834.0_TTbar_14TeV+2022PU Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Mon Nov 25 12:42:30 2024-date Mon Nov 25 12:42:30 2024; exit: 0 0 0 0

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46793/42778

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opts = -w upgrade
  • relvals = 11834.0, 13434.0, 11834.99, 11834.13, 11834.19, 11834.21, 11846.0, 11846.19

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d31b8/43054/summary.html
COMMIT: 2098aa8
CMSSW: CMSSW_15_0_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46793/43054/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

----- Begin Fatal Exception 25-Nov-2024 13:38:22 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@srimanob
Copy link
Contributor

@AdrianoDee
Copy link
Contributor Author

/RelValMinBias_14TeV/CMSSW_12_5_0_pre4-124X_mcRun3_2022_realistic_v10_Run3FastSim_FastSim-v1/GEN-SIM

Actually also this has no more files on disk. I think the problem here is that, given the change of name, the bot is no more able to use the cached files (@smuzaffar)? While for 2022 we have some new MinBias, for 2022FS we don't. I'll have to resubmit a new MinBias batch.

@smuzaffar
Copy link
Contributor

Actually also this has no more files on disk. I think the problem here is that, given the change of name, the bot is no more able to use the cached files (@smuzaffar)?

correct, if query is changed then bot can not use the cached files. I will try to use the new file and will will try to cache those new files as long as they are accessible via xrootd

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

Pull request #46793 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d31b8/43316/summary.html
COMMIT: 6643cc7
CMSSW: CMSSW_15_0_X_2024-12-08-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46793/43316/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11834.0 step 2
11834.13 step 2
11834.19 step 2
11834.21 step 2
11834.99 step 2
11846.0 step 2
11846.19 step 2
13434.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Dec 9, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dc3efc8 into cms-sw:master Dec 9, 2024
@AdrianoDee AdrianoDee deleted the fix_2022_default_datasets branch December 10, 2024 12:19
@iarspider
Copy link
Contributor

@AdrianoDee now the 2023 WFs are failing:
image

@AdrianoDee
Copy link
Contributor Author

Yes I see, but it does not depends on this PR. For some reason the bot is no more able to fetch the input datasets.

@iarspider
Copy link
Contributor

I don't think dataset RelValMinBias_14TeV/1/GEN-SIM is valid, right?

@AdrianoDee
Copy link
Contributor Author

Ok this is my bad. Sorry. Let me fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants