Skip to content

Conversation

@stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Nov 13, 2024

PR description:

This PR adds an additional selection on the number of pixel clusters in the PbPb UPC monopole skim, which reduces the number of events by a factor of 4.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

test parameters:

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f41789/42811/summary.html
COMMIT: 541fddd
CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46691/42811/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f41789/42811/git-merge-result

@mandrenguyen
Copy link
Contributor

test parameters:

  • workflows = 143.201,143.202

@mandrenguyen
Copy link
Contributor

please test
Let's try that again. I mistakenly linked a 14_1_X PR.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f41789/42812/summary.html
COMMIT: 541fddd
CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46691/42812/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3605211
  • DQMHistoTests: Total failures: 425
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3604765
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 143.201 ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 143.201 ): 0.004 KiB MessageLogger/Warnings
  • Checked 211 log files, 181 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20f1fce into cms-sw:master Nov 13, 2024
@stahlleiton stahlleiton deleted the MonopoleSkim_14_2_X branch November 13, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants