Skip to content

Conversation

@bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 6, 2024

PR description:

The first attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565

PR validation:

Tested using scripts in SimG4Core/PrintGeomInfo/test/python and also the scenario 32434.0 of runTheMatrix.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46610/42507

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/MuonCommonData (geometry)
  • SimG4Core/PrintGeomInfo (simulation)

@AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @ptcox, @rovere, @sameasy, @slomeo, @vargasa, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Nov 6, 2024

test parameters:

  • workflows = 32434.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,Run4

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 6, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ffbe/42616/summary.html
COMMIT: 19ede6d
CMSSW: CMSSW_14_2_X_2024-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46610/42616/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

@civanch
Copy link
Contributor

civanch commented Nov 6, 2024

@bsunanda , there are 64 cases when /2026/ directories are used. Likely we should not remove them now but should we created /run4/ instead and switch to this?

@cmsbuild cmsbuild mentioned this pull request Nov 7, 2024
3 tasks
@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 7, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ffbe/42661/summary.html
COMMIT: 19ede6d
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46610/42661/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2022.0000012022.000001_RunJetHT2022C_10k/step1_dasquery.log
  • 2022.000001DAS Error

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ffbe/42897/summary.html
COMMIT: 2e0f687
CMSSW: CMSSW_14_2_X_2024-11-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46610/42897/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343764
  • DQMHistoTests: Total failures: 514
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343230
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 16, 2024

+1

@bsunanda
Copy link
Contributor Author

@Moanwar, @subirsarkar Please approve this PR

@bsunanda
Copy link
Contributor Author

@AdrianoDee, @DickyChant Please approve this PR

@subirsarkar
Copy link

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@bsunanda
Copy link
Contributor Author

@antoniovilela, @mandrenguyen, Please approve and merge this PR

@bsunanda
Copy link
Contributor Author

Impossible to remove the conflicts. So closing this in view of #46755

@bsunanda bsunanda closed this Nov 21, 2024
cmsbuild added a commit that referenced this pull request Nov 25, 2024
Phase2-hgx360FX Attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 and #46610
tschuh pushed a commit to cms-L1TK/cmssw that referenced this pull request Jan 9, 2025
LinaresToine pushed a commit to LinaresToine/cmssw that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants