Skip to content

Add WF for 2024 PbPb skim #46589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Nov 5, 2024
Merged

Add WF for 2024 PbPb skim #46589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15283d2
Add wf for 2024 PbPb skim
youyingli Nov 2, 2024
8762928
Modify to standard rawprime wf
youyingli Nov 2, 2024
6011a57
Add missing hiDefaults2024_approxClusters
youyingli Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Configuration/PyReleaseValidation/python/relval_standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,10 @@
workflows[142.901] = ['',['RunUPC2023','RECODR3_2024_UPC','HARVESTDPROMPTR3']]
workflows[142.902] = ['',['RunUPC2023','RECODR3_2024_HIN','HARVESTDPROMPTR3']]

### run3-2024 skim (2024 HI MC temp)
workflows[143.201] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIFORWARDRUN3_2024','HARVESTHI2024']]
workflows[143.202] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIPHYSICSRAWPRIMERUN3_2024','HARVESTHI2024']]
Copy link
Contributor

@mmusich mmusich Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think the rawprime wf should use the rawprime reco.
see

cmssw/Configuration/PyReleaseValidation/python/relval_standard.py

Line 874 in 15283d2

workflows[161.03] = ['',['HydjetQ_MinBias_5362GeV_2024','DIGIHI2024','RAWPRIMESIMHI18','RECOHI2024PROD','MINIHI2023PROD']]

Copy link
Contributor Author

@youyingli youyingli Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's follow this wf.

Copy link
Contributor

@mmusich mmusich Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if you run SKIMHIPHYSICSRAWPRIMERUN3_2024 as defined right now, you are not using the strip approximate cluster modifier used in RECOHI2024PROD:

cmssw/Configuration/PyReleaseValidation/python/relval_steps.py

Lines 3261 to 3266 in ce4d0b1

steps['RECOHI2024PROD']=merge([hiDefaults2024_approxClusters,{'-s':'RAW2DIGI,L1Reco,RECO',
'--datatier':'AODSIM',
'--eventcontent':'AODSIM',
'--era':'Run3_pp_on_PbPb_2024',
},step3Up2015Defaults])

then's pointless to run the RAWPRIMESIMHI18 step in between as you'll just consume the regular raw and not rawprime.

Copy link
Contributor Author

@youyingli youyingli Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Now it's added. If it's correct, please test.


### run2-2016 (2024 PA UPC rereco data)
workflows[142.903] = ['',['RunUPC2016PA','RECODR2_2016_UPC','HARVEST2016']]

Expand Down
4 changes: 3 additions & 1 deletion Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3175,7 +3175,6 @@ def gen2024HiMix(fragment,howMuch):
else:
steps['SKIM'+s.upper()+'RUN3_reHLT_2023'] = merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:%s,PAT,NANO,DQM:@standardDQM+@miniAODDQM+@nanoAODDQM'%(autoSkim[s])},steps['RECONANORUN3_reHLT_2023']])


# mask away - to be removed once we'll migrate the matrix to be fully unscheduled for RECO step
#steps['RECOmAOD']=merge([step3DefaultsUnsch])
#steps['RECOmAODUP15']=merge([step3Up2015DefaultsUnsch])
Expand Down Expand Up @@ -3271,6 +3270,9 @@ def gen2024HiMix(fragment,howMuch):
'--procModifiers':'genJetSubEvent',
},step3Up2015Defaults])

steps['SKIMHIFORWARDRUN3_2024'] = merge([hiDefaults2024, {'-s':'RAW2DIGI,L1Reco,RECO,SKIM:UPCMonopole,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@miniAODDQM'},steps['RECOHI2024']])
steps['SKIMHIPHYSICSRAWPRIMERUN3_2024'] = merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:PbPbEMu+PbPbZEE+PbPbZMu+PbPbHighPtJets,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@miniAODDQM'},steps['RECOHI2024']])

steps['MINIHI2024PROD']=merge([hiDefaults2024,{'-s':'PAT',
'--datatier':'MINIAODSIM',
'--eventcontent':'MINIAODSIM',
Expand Down