Skip to content

Conversation

@AdrianoDee
Copy link
Contributor

PR description:

This PR proposes the removal of the --pileup and --pileup_input flags for all the "non-Digi" steps of the PU ProdLike wfs (RECO,MINI,NANO).

solves #46121

PR validation:

*.21 wfs run

@AdrianoDee AdrianoDee marked this pull request as ready for review October 28, 2024 05:46
@AdrianoDee
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46521/42378

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test wf 13034.21

@AdrianoDee
Copy link
Contributor Author

please test workflow 13034.21

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-644416/42408/summary.html
COMMIT: e39b9cc
CMSSW: CMSSW_14_2_X_2024-10-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46521/42408/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Oct 31, 2024

+Upgrade
Thanks! @AdrianoDee

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0e656bb into cms-sw:master Oct 31, 2024
@AdrianoDee AdrianoDee deleted the nopu_prodlike branch November 15, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants