Skip to content

Conversation

@hjbossi
Copy link
Contributor

@hjbossi hjbossi commented Oct 23, 2024

PR description:

This PR is a fix for the ZDC L1 emulation. Previously, the Et Sums were "compressed" to a value of 0 to 255, which is typical for the HCAL setup. However for the ZDC Et Sums, we would like the Et sums to go from 0 to 1023 in order to be consistent with what is included in the firmware. As the ZDC 1n OR trigger threshold is 16, this compression is not noticeable in the ZDC trigger rates, or emulated sums when focusing on lower values. However, when considering higher values this issue becomes clear.

PR validation:

This was tested using 10,000 events, using a replay of 2023 data using 14_1_X see slides.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #46500

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hjbossi for CMSSW_14_1_X.

It involves the following packages:

  • L1Trigger/L1TZDC (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

urgent

@hjbossi
Copy link
Contributor Author

hjbossi commented Oct 24, 2024

@aloeliger @epalencia do you mind taking a look at this?

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a922d7/42385/summary.html
COMMIT: 3d4841f
CMSSW: CMSSW_14_1_X_2024-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46501/42385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3562812
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b6f30a5 into cms-sw:CMSSW_14_1_X Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants