-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Backport of ZDC Emulation Fix. #46501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @hjbossi for CMSSW_14_1_X. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
urgent |
|
@aloeliger @epalencia do you mind taking a look at this? |
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
|
+1 |
PR description:
This PR is a fix for the ZDC L1 emulation. Previously, the Et Sums were "compressed" to a value of 0 to 255, which is typical for the HCAL setup. However for the ZDC Et Sums, we would like the Et sums to go from 0 to 1023 in order to be consistent with what is included in the firmware. As the ZDC 1n OR trigger threshold is 16, this compression is not noticeable in the ZDC trigger rates, or emulated sums when focusing on lower values. However, when considering higher values this issue becomes clear.
PR validation:
This was tested using 10,000 events, using a replay of 2023 data using 14_1_X see slides.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport of #46500