Skip to content

[14_1_X] Adding unbiased superclusters to miniAOD and EGM nano #46477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Oct 25, 2024
Merged

[14_1_X] Adding unbiased superclusters to miniAOD and EGM nano #46477

cmsbuild merged 1 commit into from
Oct 25, 2024

Conversation

@stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Oct 22, 2024

Backport of #46423

@mandrenguyen

@cmsbuild
Merge pull request cms-sw#46423 from SanghyunKo/unbiasedMiniAODsuperClus
e803321 
Adding unbiased superclusters to miniAOD and EGM nano
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Oct 22, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2024 •
edited
Loading

A new Pull Request was created by @stahlleiton for CMSSW_14_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoEgamma/EgammaIsolationAlgos (reconstruction)
  • RecoEgamma/EgammaPhotonProducers (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Prasant1993, @Sam-Harper, @Senphy, @a-kapoor, @afiqaize, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @jdamgov, @jdolen, @lgray, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @nhanvtran, @ram1123, @rappoccio, @rovere, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2024 •
edited
Loading

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Oct 22, 2024

enable nano

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Oct 22, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2024

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23833c/42342/summary.html
COMMIT: e803321
CMSSW: CMSSW_14_1_X_2024-10-22-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46477/42342/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 434 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331633
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331610
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 267 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 116 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54897
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54897
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.593 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.582 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.949 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.791 2.788 0.003 ( +0.1% ) 3.25 3.31 -1.8% 6.210 6.112
2500.002 2.904 2.901 0.003 ( +0.1% ) 2.91 2.97 -2.0% 6.446 6.401
2500.003 2.851 2.848 0.003 ( +0.1% ) 3.03 3.06 -0.8% 6.368 6.390
2500.011 1.456 1.450 0.006 ( +0.4% ) 5.61 5.71 -1.7% 2.407 2.135
2500.012 1.914 1.909 0.005 ( +0.2% ) 3.11 3.11 -0.3% 2.591 2.171
2500.013 1.770 1.765 0.005 ( +0.3% ) 4.46 4.55 -2.0% 2.513 2.193
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.94 0.97 -3.5% 2.389 2.365
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.89 0.92 -3.7% 2.384 2.360
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.90 0.93 -3.1% 2.246 2.235
2500.024 0.022 0.022 0.000 ( +0.5% ) 0.68 0.70 -3.1% 2.475 2.374
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.85 0.88 -3.7% 2.453 2.410
2500.032 0.036 0.036 0.000 ( +0.1% ) 0.87 0.91 -4.3% 2.415 2.402
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.78 0.79 -2.1% 2.501 2.421
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.77 0.81 -5.6% 2.467 2.407
2500.101 2.649 2.649 0.000 ( +0.0% ) 8.52 8.90 -4.3% 6.327 6.319
2500.111 1.339 1.339 0.000 ( +0.0% ) 19.57 20.12 -2.7% 2.172 2.187
2500.112 1.745 1.745 0.000 ( +0.0% ) 15.77 16.23 -2.8% 2.286 2.281
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.56 18.56 -5.4% 1.470 1.481
2500.201 2.478 2.478 0.000 ( +0.0% ) 7.20 7.48 -3.8% 5.627 5.602
2500.211 1.592 1.592 0.000 ( +0.0% ) 17.42 17.98 -3.1% 2.266 2.264
2500.212 2.033 2.033 0.000 ( +0.0% ) 13.79 14.55 -5.3% 2.358 2.357
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.59 7.83 -3.1% 2.435 2.436
2500.222 3.140 3.072 0.069 ( +2.2% ) 6.92 7.73 -10.5% 2.528 2.524
2500.223 8.888 8.888 0.000 ( +0.0% ) 2.72 2.84 -4.0% 2.350 2.320
2500.224 5.515 5.515 0.000 ( +0.0% ) 1.07 1.10 -3.3% 2.135 2.125
2500.225 5.533 5.533 0.000 ( +0.0% ) 0.99 1.02 -3.1% 2.150 2.136
2500.226 2.973 2.973 0.000 ( +0.0% ) 7.10 7.68 -7.6% 2.231 2.183
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.42 11.95 -4.4% 1.428 1.424
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.25 13.97 -5.2% 1.900 1.897
2500.232 2.199 2.145 0.054 ( +2.5% ) 12.72 14.18 -10.3% 2.260 2.253
2500.233 4.670 4.670 0.000 ( +0.0% ) 4.79 4.91 -2.5% 2.278 2.014
2500.234 3.307 3.307 0.000 ( +0.0% ) 1.47 1.51 -2.6% 2.298 2.050
2500.235 3.317 3.317 0.000 ( +0.0% ) 1.36 1.40 -3.1% 2.321 2.059
2500.236 2.085 2.085 0.000 ( +0.0% ) 13.38 14.05 -4.7% 2.253 2.249
2500.237 1.016 1.016 0.000 ( +0.0% ) 16.99 17.39 -2.3% 1.462 1.457
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.36 3.66 -8.3% 1.911 1.911
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.86 0.90 -4.0% 1.696 1.699
2500.243 2.712 2.712 0.000 ( +0.0% ) 8.17 8.68 -5.9% 1.061 1.064
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.55 0.57 -4.1% 1.670 1.683
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.72 0.75 -4.1% 1.685 1.682
2500.901 1.749 1.749 0.000 ( +0.0% ) 20.57 22.09 -6.9% 1.831 1.830
2500.902 1.598 1.598 0.000 ( +0.0% ) 20.72 21.86 -5.2% 1.760 1.762
2500.911 13.931 13.931 0.000 ( +0.0% ) 1.82 2.19 -16.7% 1.078 1.077
2500.912 0.310 0.310 0.000 ( +0.0% ) 1.95 1.34 +44.9% 0.966 0.968
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.01 1.14 -11.7% 0.971 0.968

@hqucms
Copy link
Contributor

hqucms commented Oct 22, 2024

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 23, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@stahlleiton stahlleiton mentioned this pull request Oct 23, 2024
Merged
@mandrenguyen
Copy link
Contributor

mandrenguyen commented Oct 25, 2024

+1

@cmsbuild cmsbuild merged commit 969c15e into cms-sw:CMSSW_14_1_X Oct 25, 2024
@stahlleiton stahlleiton deleted the UnbiasedSC_14_1_X branch October 25, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-ok fully-signed orp-approved reconstruction-approved tests-approved xpog-approved

Projects

None yet

Milestone

CMSSW_14_1_X

Development

Successfully merging this pull request may close these issues.

5 participants

@stahlleiton @cmsbuild @mandrenguyen @hqucms @jfernan2