Skip to content

Conversation

@stahlleiton
Copy link
Contributor

PR description:

This PR adds a new skim for UPC monopoles to be used on the 2024 PbPb HIForward PDs.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

What's the expected rate / size of this skim?

@stahlleiton
Copy link
Contributor Author

What's the expected rate / size of this skim?

The expected rate of this skim is of the order of ~60 Hz

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46434 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

@mandrenguyen
Copy link
Contributor

@cms-sw/pdmv-l2 How should we go about testing the prompt skims for this years PbPb data taking?

@youyingli
Copy link
Contributor

youyingli commented Oct 18, 2024

Could you please also add the following codes in autoSkim.py?

# For 2024 PbPb skims
for i_split in range(20):
    autoSkim[f'HIForward{i_split}'] = 'UPCMonopole+LogError+LogErrorMonitor'

PR description:

This PR adds a new skim for UPC monopoles to be used on the 2024 PbPb HIForward PDs.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46434 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

@stahlleiton
Copy link
Contributor Author

Could you please also add the following codes in autoSkim.py?

# For 2024 PbPb skims
for i_split in range(20):
    autoSkim[f'HIForward{i_split}'] = 'UPCMonopole+LogError+LogErrorMonitor'

PR description:

This PR adds a new skim for UPC monopoles to be used on the 2024 PbPb HIForward PDs.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X

Done, this is implemented in latest commit

@youyingli
Copy link
Contributor

@cms-sw/pdmv-l2 How should we go about testing the prompt skims for this years PbPb data taking?

Since the HLT_HIUPC_MinPixelThrust0p8_MaxPixelCluster10000 is a new trigger in the 2024 HI Run, there is no existing data (from 2023) for test. However, in fact, before CMSSW is deployed to T0 for prompt reconstruction, T0 guys will take a few RAW data to test this new CMSSW version and produce so-called REPLAY data (including RECO, AOD MINIAOD, skim,...). I suggest that you can take this REPLAY data from T0 (or DAS) to check the skim. @cms-sw/pdmv-l2, how do you think? The PR and its backport should be merged quickly.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46434/42352

@cmsbuild
Copy link
Contributor

Pull request #46434 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be5129/42387/summary.html
COMMIT: b053d98
CMSSW: CMSSW_14_2_X_2024-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46434/42387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566343
  • DQMHistoTests: Total failures: 413
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565910
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

urgent

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 515a950 into cms-sw:master Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants