Skip to content

[LLVM Analyzer][ALCA,ANALYSIS] Remove dead assignments #46262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Oct 8, 2024
Merged

[LLVM Analyzer][ALCA,ANALYSIS] Remove dead assignments #46262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
595c99b
[LLVM Analyzer][ALCA,ANALYSIS] Remove dead assignments
iarspider Oct 4, 2024
d280114
Changes from review
iarspider Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion IORawData/DTCommissioning/plugins/DTNewROS8FileReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ int DTNewROS8FileReader::fillRawData(Event& e,
//2.- Get the HEADER ============================================================================
int datahead[numberEventHeadWords];
for (int iih = 0; iih < numberEventHeadWords; iih++) {
nread = inputFile.read(dataPointer<int>(&datahead[iih]), ros8WordLenght);
inputFile.read(dataPointer<int>(&datahead[iih]), ros8WordLenght);
}

//3.- ROS DATA & 4.- PU DATA (Trigger) =======================================================
Expand Down
2 changes: 1 addition & 1 deletion IORawData/SiPixelInputSources/src/PixelSLinkDataInputSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ bool PixelSLinkDataInputSource::setRunAndEventInfo(edm::EventID &id,
buffers = std::make_unique<FEDRawDataCollection>();

// uint32_t currenteventnumber = (m_data >> 32)&0x00ffffff;
Copy link
Contributor

@perrotta perrotta Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, because no currenteventnumber variable exists anywhere in this code

Suggested change
// uint32_t currenteventnumber = (m_data >> 32)&0x00ffffff;

uint32_t eventnumber = (m_data >> 32) & 0x00ffffff;
uint32_t eventnumber = 0;

do {
std::vector<uint64_t> buffer;
Expand Down
1 change: 0 additions & 1 deletion JetMETCorrections/MCJet/bin/ReadTree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ int main(int argc, char **argv) {
if (cut_ptmin && cut_dR && cut_njets) {
ind_pt = getBin(ptGen, pt_vec);
ind_eta = getBin(etaJet, eta_vec);
resp = 0.;
if (UseRatioForResponse && ptGen > 0)
resp = ptJet / ptGen;
else
Expand Down