[LLVM Analyzer][Gen] Cleanup dead assignments reported by llvm analyzer

[iarspider]

PR description:

This fixes clang-analyzer warnings https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-09-29-0000/el8_amd64_gcc12/llvm-analysis/index.html

PR validation:

Bot tests

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46260/42083

• There are other open Pull requests which might conflict with changes you have proposed:
  • File GeneratorInterface/LHEInterface/plugins/ExternalLHEProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• GeneratorInterface/ExhumeInterface (generators)
• GeneratorInterface/GenFilters (generators)
• GeneratorInterface/LHEInterface (generators)
• GeneratorInterface/ReggeGribovPartonMCInterface (generators)
• GeneratorInterface/SherpaInterface (generators)

@bbilin, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @mkirsano, @thuer this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08eb24/41969/summary.html
COMMIT: 49d4b30
CMSSW: CMSSW_14_2_X_2024-10-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46260/41969/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [FASTSIM] Applying code checks/format #46208
• @smuzaffar [DB] Applying code checks/format #46219
• @duff-ae AlcaPCCEventProducer configuration to save per ROC data #46231
• @smuzaffar [RECONSTRUCTION] Applying code checks/format #46212
• @smuzaffar [SIMULATION] Applying code checks/format #46213
• @smuzaffar [VISUALIZATION] Applying code checks/format #46211
• @smuzaffar [ANALYSIS] Applying code checks/format #46205
• @smuzaffar [GEOMETRY] Applying code checks/format #46214
• @iarspider [LLVM Analysis] Fix potential memory leak in ApvAnalysisFactory::constructAuxiliaryApvClasses (pt 2) #46226
• @smuzaffar [ANALYSIS] [Clang]Cleanup clang-analyzer warnings #46232
• @battibass [DB] Ad a small feature to DT calibration payloads dumper #46224
• @smuzaffar [SIMULATION-UPGRADE] [Clang]Cleanup clang-analyzer warnings #46239
• @denizsun [HCAL-DQM] New plot BadQualityEvents vs all LS and changes of alarm threshold for CapID and BadQEvents for CMSSW_14_2_X  #46173
• @smuzaffar [SIMULATION] [Clang]Cleanup clang-analyzer warnings #46238
• @smuzaffar [RECONSTRUCTION] [Clang]Cleanup clang-analyzer warnings #46233

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08eb24/41969/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08eb24/41969/git-merge-result

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 19 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 1694
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329622
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[iarspider]

@cms-sw/generators-l2 gentle ping

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[iarspider]

@cms-sw/generators-l2 could you please review this?

[lviliani]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1