[CORE] [Clang]Cleanup clang-analyzer warnings #46229
Conversation
|
cms-bot internal usage |
| double s2 = 2.0 * t * t; | ||
|
|
||
| for (a = 0, b = 0; b < n; b += 2 * dual) { | ||
| for (b = 0; b < n; b += 2 * dual) { |
There was a problem hiding this comment.
looks like a is not used in this loop
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46229/42041 |
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| if (failed) { | ||
| i--; | ||
| for (; i <= 0; i--) | ||
| for (; i >= 0; i--) |
There was a problem hiding this comment.
kind of infinite loop for i=-1 e.g. when https://github.com/cms-sw/cmssw/blob/master/Validation/Performance/bin/array.c#L17-L23 failed for first item i=0.
There was a problem hiding this comment.
and i think it was memory leak for i>0
|
How about we remove all these, as well as the |
sounds good to me |
|
@makortel , you meant |
Ah, yes, |
|
done #46235 . If that looks good then I can close this PR |
|
closing in favor of #46235 |
3 participants
This PR fixes clang-analyzer warnings https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12/build-logs/ .