Skip to content

Option to print periodically from SimpleMemoryCheck #46161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Oct 2, 2024
Merged

Option to print periodically from SimpleMemoryCheck #46161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion FWCore/Services/plugins/SimpleMemoryCheck.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ namespace edm {
//options
bool showMallocInfo_;
bool oncePerEventMode_;
bool printEachTime_;
bool jobReportOutputOnly_;
bool monitorPssAndPrivate_;
std::atomic<int> count_;
Expand Down Expand Up @@ -338,6 +339,7 @@ namespace edm {
num_to_skip_(iPS.getUntrackedParameter<int>("ignoreTotal")),
showMallocInfo_(iPS.getUntrackedParameter<bool>("showMallocInfo")),
oncePerEventMode_(iPS.getUntrackedParameter<bool>("oncePerEventMode")),
printEachTime_(oncePerEventMode_ or iPS.getUntrackedParameter<bool>("printEachSample")),
jobReportOutputOnly_(iPS.getUntrackedParameter<bool>("jobReportOutputOnly")),
monitorPssAndPrivate_(iPS.getUntrackedParameter<bool>("monitorPssAndPrivate")),
count_(),
Expand Down Expand Up @@ -422,6 +424,8 @@ namespace edm {
->setComment(
"Use a special thread to sample memory at the set rate. A value of 0 means no sampling. This option "
"cannot be used with 'oncePerEventMode' or 'moduleMemorySummary'.");
desc.addUntracked<bool>("printEachSample", false)
->setComment("If sampling on, print each sample taken else will print only when sample is the largest seen.");
desc.addUntracked<bool>("showMallocInfo", false);
desc.addUntracked<bool>("oncePerEventMode", false)
->setComment(
Expand Down Expand Up @@ -897,7 +901,7 @@ namespace edm {
void SimpleMemoryCheck::andPrint(std::string const& type,
std::string const& mdlabel,
std::string const& mdname) const {
if (not jobReportOutputOnly_ && ((*current_ > max_) || oncePerEventMode_)) {
if (not jobReportOutputOnly_ && ((*current_ > max_) || printEachTime_)) {
if (count_ >= num_to_skip_) {
double deltaVSIZE = current_->vsize - max_.vsize;
double deltaRSS = current_->rss - max_.rss;
Expand Down