SimpleMemoryCheck can now sample memory at a set frequency #46081

Dr15Jones · 2024-09-20T19:42:12Z

PR description:

Added time based memory sampling
Also added comments in fillDescriptions

PR validation:

Code compiles. Made a simple configuration to test the service change and it worked.

Dr15Jones · 2024-09-20T19:42:20Z

please test

cmsbuild · 2024-09-20T19:42:37Z

cms-bot internal usage

cmsbuild · 2024-09-20T19:45:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46081/41870

cmsbuild · 2024-09-20T19:46:02Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Services (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-09-20T20:25:54Z

FWCore/Services/plugins/SimpleMemoryCheck.cc

+              << "'sampleEventNSeconds' and 'moduleSummaryRequested' cannot be used together";
+        }
+        iReg.watchPostBeginJob(this, &SimpleMemoryCheck::startSamplingThread);
+        iReg.watchPreEndJob(this, &SimpleMemoryCheck::stopSamplingThread);


Does this need to listen the early termination signals too, or do we call PreEndJob after those?

I guess with #45434 we try to call EndJob if it is possible in any way (alternative being the job terminating via std::terminate() or similar)?

I agree that the EndJob transition should be run after early termination.

I agree also. That is what it should be doing.

cmsbuild · 2024-09-20T23:11:17Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385143/41676/summary.html
COMMIT: ec059a1
CMSSW: CMSSW_14_2_X_2024-09-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46081/41676/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2023.1010012023.101001_RunDisplacedJet2023D_10k/step1_dasquery.log
2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
2023.101001DAS Error

Expand to see more relval errors ...

2024.000001

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 80 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 4867
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326271
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

makortel · 2024-09-23T13:57:23Z

Comparison differences are related to #39803

makortel · 2024-09-23T14:27:45Z

FWCore/Services/plugins/SimpleMemoryCheck.cc


+      if (sampleEveryNSeconds_ > 0) {
+        if (oncePerEventMode_) {
+          throw cms::Exception("BadConfigOptions")


Should this use

Suggested change

throw cms::Exception("BadConfigOptions")

throw cms::Exception("Configuration")

or

Suggested change

throw cms::Exception("BadConfigOptions")

throw edm::Exception(edm::errors::Configuration)

?

Also added comments in fillDescriptions

cmsbuild · 2024-09-23T15:54:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46081/41891

cmsbuild · 2024-09-23T15:54:31Z

Pull request #46081 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

Dr15Jones · 2024-09-23T17:44:36Z

please test

cmsbuild · 2024-09-23T20:45:24Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385143/41712/summary.html
COMMIT: 14a946f
CMSSW: CMSSW_14_2_X_2024-09-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46081/41712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331116
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3331081
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

makortel · 2024-09-23T20:53:56Z

+core

cmsbuild · 2024-09-23T20:54:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-09-24T01:53:30Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Sep 20, 2024

cmsbuild added core-pending pending-signatures orp-pending tests-started code-checks-pending labels Sep 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 20, 2024

makortel mentioned this pull request Sep 20, 2024

SimpleMemoryCheck can now sample memory at a set frequency cms-sw/framework-team#1035

Closed

makortel reviewed Sep 20, 2024

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Sep 20, 2024

makortel reviewed Sep 23, 2024

View reviewed changes

SimpleMemoryCheck can now sample memory at a set frequency

14a946f

Also added comments in fillDescriptions

Dr15Jones force-pushed the sampleSimpleMemoryCheck branch from ec059a1 to 14a946f Compare September 23, 2024 15:50

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 23, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 23, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 23, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 23, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 23, 2024

cmsbuild added orp-approved and removed orp-pending labels Sep 24, 2024

cmsbuild merged commit 0898d62 into cms-sw:master Sep 24, 2024

cmsbuild mentioned this pull request Sep 24, 2024

[ROOT6] Root update master 20240924 cms-sw/cmsdist#9433

Closed

Dr15Jones deleted the sampleSimpleMemoryCheck branch September 27, 2024 19:19

	throw cms::Exception("BadConfigOptions")
	throw cms::Exception("Configuration")

	throw cms::Exception("BadConfigOptions")
	throw edm::Exception(edm::errors::Configuration)

SimpleMemoryCheck can now sample memory at a set frequency #46081

SimpleMemoryCheck can now sample memory at a set frequency #46081

Uh oh!

Conversation

Dr15Jones commented Sep 20, 2024

PR description:

PR validation:

Uh oh!

Dr15Jones commented Sep 20, 2024

Uh oh!

cmsbuild commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 20, 2024

Uh oh!

cmsbuild commented Sep 20, 2024

Uh oh!

makortel Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

makortel Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

Dr15Jones Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

wddgit Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Sep 20, 2024

RelVals-INPUT

Comparison Summary

Uh oh!

makortel commented Sep 23, 2024

Uh oh!

makortel Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Sep 23, 2024

Uh oh!

cmsbuild commented Sep 23, 2024

Uh oh!

Dr15Jones commented Sep 23, 2024

Uh oh!

cmsbuild commented Sep 23, 2024

Comparison Summary

Uh oh!

makortel commented Sep 23, 2024

Uh oh!

cmsbuild commented Sep 23, 2024

Uh oh!

mandrenguyen commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Sep 20, 2024 •

edited

Loading

wddgit Sep 20, 2024 •

edited

Loading