Skip to content

Add 2024 FastSim workflow #46068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Oct 2, 2024
Merged

Add 2024 FastSim workflow #46068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d8694
Add 2024FS
Sep 19, 2024
4211218
Fix wf ID
Sep 19, 2024
0c0a407
update temporary PU
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/PyReleaseValidation/python/relval_2017.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
12834.0,13034.0,13034.99,13034.21,
12834.7,
12834.402, 12834.412,
14434.0, 14634.0, 14440.303,
16434.0, 16634.0, 16440.303,
12846.0,
12861.0]

Expand Down
1 change: 1 addition & 0 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4377,6 +4377,7 @@ def gen2024HiMix(fragment,howMuch):
defaultDataSets['2024']='CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets['2024HLTOnDigi']='CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets["2024SimOnGen"] = 'CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets['2024FS']='CMSSW_13_0_11-130X_mcRun3_2023_realistic_withEarly2023BS_v1_FastSim-v' #To replace with new dataset
Copy link
Contributor

@AdrianoDee AdrianoDee Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srimanob if it is useful to have a new production let us know on JIRA and we can organize this :-)

defaultDataSets['2026D49']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D49noPU-v'
defaultDataSets['2026D76']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D76noPU-v'
defaultDataSets['2026D77']='CMSSW_12_1_0_pre2-113X_mcRun4_realistic_v7_2026D77noPU-v'
Expand Down
14 changes: 12 additions & 2 deletions Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
'2024HLTOnDigiPU',
'2024GenOnly',
'2024SimOnGen',
'2024FS',
'2024FSPU',
]

upgradeKeys[2026] = [
Expand Down Expand Up @@ -2728,7 +2730,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
else:
stepDict[stepName][k] = merge([stepDict[step][k]])
def condition(self, fragment, stepList, key, hasHarvest):
return ('2021FS' in key or '2023FS' in key)
return ('FS' in key)
upgradeWFs['Run3FStrackingOnly'] = UpgradeWorkflow_Run3FStrackingOnly(
steps = [
'Gen',
Expand All @@ -2755,7 +2757,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
else:
stepDict[stepName][k] = None
def condition(self, fragment, stepList, key, hasHarvest):
return ('2021FS' in key or '2023FS' in key) and fragment=="MinBias_14TeV"
return ('FS' in key) and fragment=="MinBias_14TeV"
upgradeWFs['Run3FSMBMixing'] = UpgradeWorkflow_Run3FSMBMixing(
steps = [
'Gen',
Expand Down Expand Up @@ -3102,6 +3104,14 @@ def condition(self, fragment, stepList, key, hasHarvest):
'BeamSpot': 'DBrealistic',
'ScenToRun' : ['Gen','Sim','Digi','RecoNano','HARVESTNano','ALCA'],
},
'2024FS' : {
'Geom' : 'DB:Extended',
'GT' : 'auto:phase1_2024_realistic',
'HLTmenu': '@relval2024',
'Era' : 'Run3_FastSim',
Copy link
Contributor

@kpedro88 kpedro88 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a dedicated Run3_2024_FastSim like there is for 2023?

Copy link
Contributor Author

@srimanob srimanob May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. Not remember why I made it in that way.

Copy link
Contributor

@kpedro88 kpedro88 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I can submit a PR to update this.

Copy link
Contributor

@kpedro88 kpedro88 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#48153

'BeamSpot': 'DBrealistic',
'ScenToRun' : ['Gen','FastSimRun3','HARVESTFastRun3'],
},
}

# standard PU sequences
Expand Down