[BTV] Disable pT cut for AK4 Puppi ParticleNet and UParT taggers inference

[nurfikri89]

PR description:

This PR makes several changes related to BTV:

• Lower jet pT cut to 0 for AK4 Puppi ParticleNet and UParT jet taggers. The jet abs(eta) range for ParticleNet is also extended to 5. This is to ensure that the taggers provide pT regression values for low pt jets. Very small timing impact on PAT step (XPOG 4/9).
• Remove hardcoded jet pT and eta selection in UnifiedParticleTransformerAK4TagInfoProducer.cc.
• Puppi weight is now retrieved from ValueMap in ParticleNetFeatureEvaluator.cc.
• Simplify setup of packedpuppi module in setupBTagging() function.

PR validation:

• passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
• passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46009/41811

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/PatAlgos/python/tools/jetTools.py modified in PR(s): [Superseded by #46523] Add GloParT inference facility #45830
  • File RecoBTag/FeatureTools/plugins/ParticleNetFeatureEvaluator.cc modified in PR(s): update PackedCandidate::dzError to return what it should in track parameterization #45612

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46009/41811/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46009/41811/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46009/41812

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/PatAlgos/python/tools/jetTools.py modified in PR(s): [Superseded by #46523] Add GloParT inference facility #45830
  • File RecoBTag/FeatureTools/plugins/ParticleNetFeatureEvaluator.cc modified in PR(s): update PackedCandidate::dzError to return what it should in track parameterization #45612

[cmsbuild]

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction, xpog)
• RecoBTag/FeatureTools (reconstruction)
• RecoBTag/ONNXRuntime (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @hqucms, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

enable profiling

[hqucms]

please test

[cmsbuild]

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-310ff8/41546/summary.html
COMMIT: 3eae945
CMSSW: CMSSW_14_2_X_2024-09-16-2300/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46009/41546/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 2256 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 356
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3330782
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[hqucms]

enable profiling,nano

[hqucms]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-310ff8/41572/summary.html
COMMIT: 3eae945
CMSSW: CMSSW_14_2_X_2024-09-17-1100/el8_amd64_gcc12
Additional Tests: PROFILING,NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46009/41572/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 2274 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 1531
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329607
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 880 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 888 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 55132
• DQMHistoTests: Total failures: 84
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 55048
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.841	2.839	0.002 ( +0.1% )	3.12	3.30	-5.5%	6.052	6.214
2500.002	2.955	2.954	0.001 ( +0.0% )	2.79	2.96	-5.7%	6.397	6.441
2500.003	2.901	2.900	0.001 ( +0.0% )	2.90	3.08	-5.7%	6.370	6.377
2500.011	1.493	1.489	0.004 ( +0.2% )	4.85	5.78	-16.2%	2.421	2.167
2500.012	1.959	1.958	0.001 ( +0.1% )	2.90	3.17	-8.5%	2.606	2.185
2500.013	1.809	1.809	0.000 ( +0.0% )	4.15	4.56	-9.2%	2.501	2.208
2500.021	0.022	0.022	0.000 ( +0.0% )	0.95	0.93	+2.5%	2.227	2.387
2500.022	0.022	0.022	0.000 ( +0.0% )	0.91	0.93	-1.6%	2.229	2.380
2500.023	0.022	0.022	0.000 ( +0.0% )	0.90	0.92	-2.0%	2.181	2.246
2500.024	0.022	0.022	0.000 ( +0.0% )	0.69	0.69	+1.3%	2.322	2.410
2500.031	0.035	0.035	0.000 ( +0.0% )	0.86	0.89	-3.7%	2.318	2.445
2500.032	0.036	0.036	0.000 ( +0.0% )	0.87	0.91	-3.5%	2.256	2.403
2500.033	0.037	0.037	0.000 ( +0.0% )	0.78	0.81	-4.3%	2.361	2.490
2500.034	0.036	0.036	0.000 ( +0.0% )	0.78	0.79	-1.4%	2.338	2.456
2500.101	2.660	2.660	0.000 ( +0.0% )	9.01	8.79	+2.6%	6.903	6.325
2500.111	1.342	1.342	0.000 ( +0.0% )	20.44	19.80	+3.2%	2.231	2.235
2500.112	1.749	1.749	0.000 ( +0.0% )	15.32	15.66	-2.2%	2.138	2.308
2500.131	0.747	0.747	0.000 ( +0.0% )	18.53	18.51	+0.1%	1.498	1.412
2500.201	2.490	2.490	0.000 ( +0.0% )	7.71	7.73	-0.3%	6.147	5.611
2500.211	1.612	1.612	0.000 ( +0.0% )	17.66	18.23	-3.1%	2.114	1.989
2500.212	2.055	2.055	0.000 ( +0.0% )	14.00	14.23	-1.6%	2.139	2.081
2500.221	2.003	2.003	0.000 ( +0.0% )	7.61	7.84	-3.0%	2.293	2.041
2500.222	3.222	3.222	0.000 ( +0.0% )	7.58	7.65	-0.9%	2.347	2.094
2500.223	8.909	8.902	0.007 ( +0.1% )	2.64	2.84	-6.9%	2.333	2.050
2500.224	5.680	5.570	0.110 ( +2.0% )	0.61	1.10	-44.9%	2.436	2.268
2500.225	5.698	5.590	0.107 ( +1.9% )	0.58	1.03	-43.8%	2.443	2.270
2500.226	2.988	2.988	0.000 ( +0.0% )	7.24	7.79	-7.1%	2.303	2.528
2500.227	1.437	1.437	0.000 ( +0.0% )	11.95	11.96	-0.1%	1.341	1.420
2500.231	1.403	1.403	0.000 ( +0.0% )	13.78	14.65	-5.9%	1.944	2.175
2500.232	2.260	2.260	0.000 ( +0.0% )	13.40	14.19	-5.6%	2.013	2.273
2500.233	4.707	4.692	0.015 ( +0.3% )	4.23	4.98	-15.0%	2.028	2.019
2500.234	3.415	3.348	0.067 ( +2.0% )	0.75	1.52	-51.0%	2.071	2.068
2500.235	3.426	3.359	0.068 ( +2.0% )	0.74	1.40	-47.2%	2.271	1.716
2500.236	2.107	2.107	0.000 ( +0.0% )	14.09	14.56	-3.2%	2.019	2.260
2500.237	1.016	1.016	0.000 ( +0.0% )	17.18	17.59	-2.3%	1.343	1.423
2500.241	9.404	9.404	0.000 ( +0.0% )	3.79	3.81	-0.6%	1.872	1.945
2500.242	10.331	10.331	0.000 ( +0.0% )	0.90	0.88	+2.4%	1.661	1.734
2500.243	2.712	2.712	0.000 ( +0.0% )	8.16	8.54	-4.4%	1.079	1.079
2500.244	485.976	485.976	0.000 ( +0.0% )	0.58	0.57	+0.3%	1.679	1.683
2500.245	823.202	823.202	0.000 ( +0.0% )	0.76	0.75	+1.0%	1.652	1.657
2500.901	1.777	1.777	0.000 ( +0.0% )	21.54	21.59	-0.2%	1.770	1.840
2500.902	1.626	1.626	0.000 ( +0.0% )	21.97	20.87	+5.2%	1.733	1.771
2500.911	13.995	13.995	0.000 ( +0.0% )	3.57	1.77	+101.3%	1.097	1.094
2500.912	0.240	0.199	0.041 ( +20.3% )	1.57	1.31	+19.9%	0.978	0.977
2500.913	0.110	0.110	0.000 ( +0.0% )	1.19	1.19	-0.1%	0.975	0.976

[jfernan2]

+1

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1