Displaced vertexing gbdt #45672

ryanm124 · 2024-08-08T16:01:55Z

Updated version of the displaced vertex producer presented at L1 DPG: https://indico.cern.ch/event/1408668/contributions/5920520/attachments/2850847/4984793/Displaced%20Vertexing%20Low%20Fake%20DP%20Note.pdf

DP Note: https://cds.cern.ch/record/2901311?ln=en

Model file for displaced vertexing GBDT: cms-data/L1Trigger-L1TTrackMatch#2

cmsbuild · 2024-08-08T16:02:22Z

cms-bot internal usage

cmsbuild · 2024-08-08T16:06:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45672/41218

Found files with invalid states:
- L1Trigger/L1TTrackMatch/test/Analyzer_DisplacedMuon.C:
  - Added: 7ab2dfd
  - Deleted: d2f8a50
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Trigger/src/classes_def.xml modified in PR(s): Phase-2 GT interface update and slice test pattern writers #45606
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690
- File L1Trigger/TrackFindingTracklet/test/L1TrackNtupleMaker.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567

cmsbuild · 2024-08-08T16:07:16Z

A new Pull Request was created by @ryanm124 for master.

It involves the following packages:

DataFormats/L1Trigger (l1)
L1Trigger/L1TTrackMatch (upgrade, l1)
L1Trigger/TrackFindingTracklet (l1)
L1Trigger/TrackTrigger (upgrade, l1)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @erikbutz, @eyigitba, @kreczko, @missirol, @mmusich, @rovere, @skinnari, @sviret, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-08-09T11:48:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45672/41234

Found files with invalid states:
- L1Trigger/TrackTrigger/data/clf_GBDT_newbin_disp_xgb.onnx:
  - Added: dc95ccb
  - Deleted: 87773c2
- L1Trigger/L1TTrackMatch/test/Analyzer_DisplacedMuon.C:
  - Added: 7ab2dfd
  - Deleted: d2f8a50
- L1Trigger/L1TTrackMatch/test/trackAndVert_NewTQMVA_model.onnx:
  - Added: 7ab2dfd
  - Deleted: 87773c2
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Trigger/src/classes_def.xml modified in PR(s): Phase-2 GT interface update and slice test pattern writers #45606
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690
- File L1Trigger/TrackFindingTracklet/test/L1TrackNtupleMaker.cc modified in PR(s): Move dictionaries (and some classes) defined in SimTracker/TrackTriggerAssociation and SimGeneral/TrackingAnalysis to more proper packages #45567

cmsbuild · 2024-08-09T11:48:41Z

Pull request #45672 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

srimanob · 2024-08-10T16:02:36Z

test parameters:

workflows = 29634.78
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

srimanob · 2024-08-10T16:03:12Z

@cmsbuild please test

srimanob · 2024-08-10T16:05:48Z

@cmsbuild please abort

srimanob · 2024-08-10T16:07:46Z

test parameters:

srimanob · 2024-08-10T16:08:47Z

@cmsbuild please test

cmsbuild · 2025-04-08T13:05:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45672/44413

Found files with invalid states:
- L1Trigger/L1TTrackMatch/test/dispVertTaggerEmulationFixedPoint.json:
  - Added: e1a92db
  - Deleted: 96b9459
- L1Trigger/TrackTrigger/data/clf_GBDT_newbin_disp_xgb.onnx:
  - Added: f64421c
  - Deleted: 96b9459
- L1Trigger/L1TTrackMatch/test/dispVertTaggerEmulationConiferShifted13p8.json:
  - Added: b2bddce
  - Deleted: d245a34
- L1Trigger/L1TTrackMatch/test/saveModelJson.py:
  - Added: b1f566a
  - Deleted: 96b9459
- L1Trigger/L1TTrackMatch/test/Analyzer_DisplacedMuon.C:
  - Added: 918ed68, 9730cab
  - Deleted: 89bdbb0, 96b9459
  - Modified: b2bddce, 577dc3c
- L1Trigger/L1TTrackMatch/test/trackAndVert_NewTQMVA_model.onnx:
  - Added: 918ed68
  - Deleted: 96b9459
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Trigger/src/classes.h modified in PR(s): Add Bs -> ϕ ϕ -> 4k analysis in GTT #47348
- File DataFormats/L1Trigger/src/classes_def.xml modified in PR(s): Add Bs -> ϕ ϕ -> 4k analysis in GTT #47348
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc modified in PR(s): L1 tracking update #47067, Add Bs -> ϕ ϕ -> 4k analysis in GTT #47348
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py modified in PR(s): L1 tracking update #47067, Add Bs -> ϕ ϕ -> 4k analysis in GTT #47348

cmsbuild · 2025-04-08T13:05:48Z

Pull request #45672 was updated. @BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @srimanob, @subirsarkar can you please check and sign again.

BenjaminRS · 2025-04-08T13:08:38Z

test parameters:

workflow = 29634.78
pull_request = Adding displaced vertexing GBDT cms-data/L1Trigger-L1TTrackMatch#2
relvals_opt = --what upgrade

BenjaminRS · 2025-04-08T13:09:10Z

please test

cmsbuild · 2025-04-08T16:26:46Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-702cac/45441/summary.html
COMMIT: 7ec02ec
CMSSW: CMSSW_15_1_X_2025-04-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45672/45441/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-702cac/45441/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-702cac/45441/git-merge-result

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 4025477
DQMHistoTests: Total failures: 735
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4024722
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 220 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

Moanwar · 2025-04-08T16:28:14Z

+Upgrade

BenjaminRS · 2025-04-08T18:09:59Z

+l1

cmsbuild · 2025-04-08T18:10:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TTrackMatch#2

mandrenguyen · 2025-04-08T18:28:37Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Aug 8, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending changes-dataformats labels Aug 8, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 8, 2024

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 9, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 9, 2024

ryanm124 marked this pull request as ready for review August 9, 2024 11:52

cmsbuild mentioned this pull request Aug 9, 2024

Phase-2 GT interface update and slice test pattern writers #45606

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 10, 2024

cmsbuild added tests-pending and removed tests-started labels Aug 10, 2024

cmsbuild added l1-pending tests-pending code-checks-pending and removed code-checks-approved labels Apr 8, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2025

cmsbuild added the requires-external label Apr 8, 2025

cmsbuild added tests-started and removed tests-pending labels Apr 8, 2025

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2025

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 8, 2025

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Apr 8, 2025

cmsbuild added orp-approved and removed orp-pending labels Apr 8, 2025

cmsbuild merged commit c4abf7a into cms-sw:master Apr 8, 2025
12 checks passed

cmsbuild mentioned this pull request Apr 8, 2025

Add the Scouting Glo-ParT inference facility #47801

Merged

Displaced vertexing gbdt #45672

Displaced vertexing gbdt #45672

Uh oh!

Conversation

ryanm124 commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 8, 2024

Uh oh!

cmsbuild commented Aug 8, 2024

Uh oh!

cmsbuild commented Aug 9, 2024

Uh oh!

cmsbuild commented Aug 9, 2024

Uh oh!

srimanob commented Aug 10, 2024

Uh oh!

srimanob commented Aug 10, 2024

Uh oh!

srimanob commented Aug 10, 2024

Uh oh!

srimanob commented Aug 10, 2024

Uh oh!

srimanob commented Aug 10, 2024

Uh oh!

cmsbuild commented Apr 8, 2025

Uh oh!

cmsbuild commented Apr 8, 2025

Uh oh!

BenjaminRS commented Apr 8, 2025

Uh oh!

BenjaminRS commented Apr 8, 2025

Uh oh!

cmsbuild commented Apr 8, 2025

Comparison Summary

Uh oh!

Moanwar commented Apr 8, 2025

Uh oh!

BenjaminRS commented Apr 8, 2025

Uh oh!

cmsbuild commented Apr 8, 2025

Uh oh!

mandrenguyen commented Apr 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ryanm124 commented Aug 8, 2024 •

edited

Loading

cmsbuild commented Aug 8, 2024 •

edited

Loading