-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[13_2_X] Introduce Unified Particle Transformer AK4 jet tagger (Backport) #45642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @stahlleiton for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
backport of #44641 |
|
Pull request #45642 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again. |
|
please test |
|
-1 Failed Tests: RelVals RelVals |
|
please test with cms-sw/cmsdist#9352 |
|
-1 Failed Tests: RelVals RelVals |
As far as I am aware of, those differences are for the b tagging discriminators (they should be made as std::pair so that users can use a string to query). In this commit, we modified the PatAlgo such that we are using UParT which has more output values ( since it is the unified approaches that has more categories etc) therefore you could find a major difference even for the size of the b pair discriminator : |
d9beb51 to
b599a18
Compare
|
Pull request #45642 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again. |
I made a commit excluding changes to NanoAOD and MiniAOD |
|
please test with cms-sw/cmsdist#9352 |
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
|
+1 |
|
+reconstruction |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Partial backport of #44641 (includes only the producers while excluding changes to nano and mini AOD).
Plan to use the unified particle transformer AK4 jet tagger on PbPb 2023 data.
This PR requires the associated ONNX model which has been included in cms-sw/cmsdist#9352
@mandrenguyen @DickyChant
PR validation:
Tested using relvals.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: