-
Notifications
You must be signed in to change notification settings - Fork 4.6k
remove SiPixelCompare*SoAAlpaka templates and update customizeHLTforAlpaka to use the new modules
#45566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove SiPixelCompare*SoAAlpaka templates and update customizeHLTforAlpaka to use the new modules
#45566
Conversation
…lpaka to use the new modules
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45566/41059
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 28KB to repository
Comparison SummarySummary:
|
|
+hlt |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
After the integration of the new HLT menu in PR #45548 (which included the ticket CMSHLT-3278 "[DQM] Use general DQM modules for pixel rechits, tracks and vertices added in cmssw#45302") we can finally proceed with removing the old-style comparison
SiPixelCompare*SoAAlpakatemplates which serve no longer any purpose.Consequently the
customizeHLTforAlpakacustomization function is updated to use the new modules.This is a "leftover" of #45206, see comment at #45206 (comment).
PR validation:
None, no regressions are expected.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, will backport to CMSSW_14_0_X.
@borzari FYI