Fixing track HT for phase2

[gkaratha]

Hello,

During the review we saw a bug in the HT calculation for the phase 2 l1t gtt. We fixed it in the l1t offline and now I am propagating it to the central. Is just a flag to take displaced tracks when we want the displaced HT

Best,
George

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45550/41030

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45550/41030/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45550/41030/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45550/41031

[cmsbuild]

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (upgrade, l1)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e7260/40583/summary.html
COMMIT: 9d41ec2
CMSSW: CMSSW_14_1_X_2024-07-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45550/40583/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 2500.2452500.245_hcalDPGCalibNANO140Xrun3/step2_hcalDPGCalibNANO140Xrun3.log

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3325254
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3322770
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[gkaratha]

As far as I can tell the test failed because the file could not be retreived:
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2024F/TestEnablesEcalHcal/RAW/Express-v1/000/383/173/00000/1088fbe0-c256-4752-992c-0e535b804bef.root'
Additional Info:

Can we try with another one?

[smuzaffar]

ignore tests-rejected with external-failure

missing file is now available in ibeos ( see #45419 (comment) ).

[epalencia]

Please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e7260/40645/summary.html
COMMIT: 9d41ec2
CMSSW: CMSSW_14_1_X_2024-07-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45550/40645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 93 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 2470
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421471
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1