Fix clang compilation issues with RecoTracker/FinalTrackSelectors

[dan131riley]

PR description:

In recent IBs, the CLANG builds are failing on RecoTracker/FinalTrackSelectors with errors like

In file included from src/RecoTracker/FinalTrackSelectors/plugins/DefaultTrackMVAClassifier.cc:1:
In file included from src/RecoTracker/FinalTrackSelectors/interface/TrackMVAClassifier.h:4:
In file included from src/DataFormats/TrackReco/interface/TrackFwd.h:4:
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/vector:60:
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/bits/stl_algobase.h:67:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/bits/stl_iterator.h:1107:2: error: arithmetic on a pointer to an incomplete type 'const reco::Track'
  1107 |         ++_M_current;
      |         ^ ~~~~~~~~~~
src/RecoTracker/FinalTrackSelectors/interface/TrackMVAClassifier.h:71:28: note: in instantiation of member function '__gnu_cxx::__normal_iterator<const reco::Track *, std::vector<reco::Track>>::operator++' requested here
   71 |       for (auto const& trk : tracks) {
      |                            ^
src/DataFormats/TrackReco/interface/TrackFwd.h:14:9: note: forward declaration of 'reco::Track'
   14 |   class Track;
      |         ^
In file included from src/RecoTracker/FinalTrackSelectors/plugins/DefaultTrackMVAClassifier.cc:1:
  src/RecoTracker/FinalTrackSelectors/interface/TrackMVAClassifier.h:86:28: error: cannot increment value of type 'const_iterator' (aka '__normal_iterator<const reco::Track *, std::vector<reco::Track, std::allocator<reco::Track>>>')
    86 |       for (auto const& trk : tracks) {
      |                            ^
src/RecoTracker/FinalTrackSelectors/interface/TrackMVAClassifier.h:86:30: note: in implicit call to 'operator++' for iterator of type 'const reco::TrackCollection' (aka 'const vector<Track>')
   86 |       for (auto const& trk : tracks) {
      |                              ^~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/bits/stl_vector.h:878:7: note: selected 'begin' function with iterator type 'const_iterator' (aka '__normal_iterator<const reco::Track *, std::vector<reco::Track, std::allocator<reco::Track>>>')
  878 |       begin() const _GLIBCXX_NOEXCEPT
      |       ^

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-14-2300/RecoTracker/FinalTrackSelectors

I don't know why these errors have suddenly appeared--perhaps a change in the includes elsewhere--but they appear to be correct. It's legitimate for the compiler to need to know sizeof(Track) at the point where it is complaining. This PR trivially adds an include of Track.h. It doesn't appear that this header is included outside of this package (according to cms-checkdeps), so this should have minimal impact elsewhere.

PR validation:

Trivial technical change, compiles, no impact on physics or timing performance expected, compilation time differences should be trivial.

[cmsbuild]

cms-bot internal usage

[dan131riley]

Never mind, redundant with #45428 @iarspider beat me to it

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45458/40918

[cmsbuild]

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

• RecoTracker/FinalTrackSelectors (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here