Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 26, 2024

PR description:

Introduce kInvalidDenseId for ECAL and HCAL, and use it instead of 0 or -1.

PR validation:

Technical-only changes, validated running the HLT over 100k events, and obtaining identical results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45238.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

backport #45239

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

type pf

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_9_patchX.

It involves the following packages:

  • RecoParticleFlow/PFRecHitProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @missirol, @mmarionncern, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
Note that this branch is designed for requested bug fixes specific to the CMSSW_14_0_9 release.
If you wish to make a pull request for the CMSSW_14_0_X release cycle, please use the CMSSW_14_0_X branch instead

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2024

cms-bot internal usage

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ef87b6c into cms-sw:CMSSW_14_0_9_patchX Jun 26, 2024
@fwyzard fwyzard deleted the introduce_kInvalidDenseId_1409x branch June 27, 2024 00:41
@jfernan2
Copy link
Contributor

jfernan2 commented Jul 2, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_9_patchX IBs after it passes the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants