Change CaloRecHitProducer to produce new HCAL RecHit SoA #45263

jsamudio · 2024-06-18T17:27:44Z

PR description:

This PR depends on #45238 and #45199. It implements changes to the CaloRecHitSoAProducer which disables the functionality of converting ECAL rechits, and changes the produced SoA to the new HCAL rechit SoA. This is the first integration step for the use of Alpaka HCAL rechits with the PFRecHitProducer.

PR validation:

Validated with workflow 12434.423 and checking the cluster DQM plots as well.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will need a backport to 14_0_X

@fwyzard @hatakeyamak @kakwok

HcalRecHit SoA dataFormat

cmsbuild · 2024-06-18T17:28:07Z

cms-bot internal usage

cmsbuild · 2024-06-18T17:32:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45263/40641

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HcalRecHit/BuildFile.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/HcalRecHitHostCollection.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/HcalRecHitSoA.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/alpaka/HcalRecHitDeviceCollection.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_cuda.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_cuda_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_rocm.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_rocm_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes.cc modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199

cmsbuild · 2024-06-18T17:32:35Z

A new Pull Request was created by @jsamudio for master.

It involves the following packages:

DataFormats/HcalRecHit (reconstruction)
RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@missirol, @seemasharmafnal, @mmusich, @lgray, @abdoulline, @bsunanda, @hatakeyamak, @mmarionncern, @rovere, @mariadalfonso this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2024-06-19T13:49:31Z

please test

fwyzard · 2024-06-19T16:38:18Z

@jsamudio could you squash the last commit into the previous one ?

fwyzard · 2024-06-19T16:38:35Z

assign heterogeneous

fwyzard · 2024-06-19T16:38:40Z

+heterogeneous

cmsbuild · 2024-06-19T16:38:42Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

Revert column name to detId Code checks and formatting

cmsbuild · 2024-06-19T18:51:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45263/40657

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HcalRecHit/BuildFile.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/HcalRecHitHostCollection.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/HcalRecHitSoA.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/interface/alpaka/HcalRecHitDeviceCollection.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_cuda.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_cuda_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_rocm.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/alpaka/classes_rocm_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes.cc modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes.h modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199
- File DataFormats/HcalRecHit/src/classes_def.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, HcalRecHit SoA dataFormat #45199

cmsbuild · 2024-06-19T18:51:45Z

Pull request #45263 was updated. @mandrenguyen, @jfernan2 can you please check and sign again.

cmsbuild · 2024-06-19T23:23:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd174/39978/summary.html
COMMIT: bcbae48
CMSSW: CMSSW_14_1_X_2024-06-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45263/39978/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345018
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344995
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

fwyzard · 2024-06-20T14:39:00Z

@jsamudio I've open the 14.0.x backport in #45278.

mandrenguyen · 2024-06-20T14:54:15Z

+1

cmsbuild · 2024-06-20T14:54:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-06-20T16:38:32Z

type pf, hcal

antoniovilela · 2024-06-20T22:24:06Z

+1

Martin and others added 2 commits June 18, 2024 12:03

HcalRecHit SoA dataFormat

0689d1b

HcalRecHit SoA dataFormat

Introduce kInvalidDenseId for ECAL and HCAL

cb5a294

cmsbuild added this to the CMSSW_14_1_X milestone Jun 18, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jun 18, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 18, 2024

cmsbuild mentioned this pull request Jun 19, 2024

Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910

Merged

cmsbuild added tests-started and removed tests-pending labels Jun 19, 2024

cmsbuild added the heterogeneous-approved label Jun 19, 2024

Produce HCAL rechit SoA in CaloRecHitSoAProducer

bcbae48

Revert column name to detId Code checks and formatting

jsamudio force-pushed the dev_PFUseHCALSoA branch from 24ee5c0 to bcbae48 Compare June 19, 2024 18:43

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 19, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 19, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 19, 2024

fwyzard mentioned this pull request Jun 20, 2024

Change CaloRecHitProducer to produce new HCAL RecHit SoA [14.0.x] #45278

Merged

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jun 20, 2024

cmsbuild added hcal pf labels Jun 20, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 20, 2024

cmsbuild merged commit 200bfa2 into cms-sw:master Jun 20, 2024

cmsbuild mentioned this pull request Jun 21, 2024

Heterogeneous Workflow (CLUE) in Phase2 HLT Simplified Menu #45178

Merged

Change CaloRecHitProducer to produce new HCAL RecHit SoA #45263

Change CaloRecHitProducer to produce new HCAL RecHit SoA #45263

Uh oh!

Conversation

jsamudio commented Jun 18, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 18, 2024

Uh oh!

cmsbuild commented Jun 18, 2024

Uh oh!

jfernan2 commented Jun 19, 2024

Uh oh!

fwyzard commented Jun 19, 2024

Uh oh!

fwyzard commented Jun 19, 2024

Uh oh!

fwyzard commented Jun 19, 2024

Uh oh!

cmsbuild commented Jun 19, 2024

Uh oh!

cmsbuild commented Jun 19, 2024

Uh oh!

cmsbuild commented Jun 19, 2024

Uh oh!

cmsbuild commented Jun 19, 2024

Comparison Summary

Uh oh!

fwyzard commented Jun 20, 2024

Uh oh!

mandrenguyen commented Jun 20, 2024

Uh oh!

cmsbuild commented Jun 20, 2024

Uh oh!

mandrenguyen commented Jun 20, 2024

Uh oh!

antoniovilela commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Jun 18, 2024 •

edited

Loading