Skip to content

Fix maybe-uninitialized warning in BaseCrystal #45130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jun 6, 2024
Merged

Fix maybe-uninitialized warning in BaseCrystal #45130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FastSimulation/CaloGeometryTools/interface/BaseCrystal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class BaseCrystal {
// side numbering
// enum CrystalSide{EAST=0,NORTH=1,WEST=2,SOUTH=3,FRONT=4,BACK=5};
/// Empty constructor
BaseCrystal() { ; };
BaseCrystal() = default;
/// constructor from DetId
BaseCrystal(const DetId& cell);

Expand All @@ -36,7 +36,7 @@ class BaseCrystal {
// computeBasicProperties();
// std::cout << " done " << std::endl;
// }
~BaseCrystal() { ; }
~BaseCrystal() = default;
///
void setCorners(const CaloCellGeometry::CornersVec& vec, const GlobalPoint& pos);

Expand Down