Skip to content

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jun 20, 2024
Merged

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Validation/RecoEgamma/plugins/ElectronConversionRejectionValidator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,16 @@ void ElectronConversionRejectionValidator::bookHistograms(DQMStore::IBooker& ibo

h_convLog10TrailTrackpt_ = ibooker.book1D("convLog10TrailTrackpt", "# of Electrons", ptBin, -2.0, 3.0);

h_convLeadTrackAlgo_ = ibooker.book1D(
"convLeadTrackAlgo", "# of Electrons", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
h_convTrailTrackAlgo_ = ibooker.book1D(
"convLeadTrackAlgo", "# of Electrons", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
h_convLeadTrackAlgo_ = ibooker.book1D("convLeadTrackAlgo",
"# of Electrons",
reco::TrackBase::algoSize,
-0.5,
static_cast<double>(reco::TrackBase::algoSize) - 0.5);
h_convTrailTrackAlgo_ = ibooker.book1D("convLeadTrackAlgo",
"# of Electrons",
reco::TrackBase::algoSize,
-0.5,
static_cast<double>(reco::TrackBase::algoSize) - 0.5);
}

void ElectronConversionRejectionValidator::analyze(const edm::Event& e, const edm::EventSetup&) {
Expand Down
7 changes: 5 additions & 2 deletions Validation/RecoEgamma/plugins/PhotonValidator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3126,8 +3126,11 @@ void PhotonValidator::bookHistograms(DQMStore::IBooker& iBooker, edm::Run const&
h_trkProv_[0] = iBooker.book1D("allTrkProv", " Track pair provenance ", 4, 0., 4.);
h_trkProv_[1] = iBooker.book1D("assTrkProv", " Track pair provenance ", 4, 0., 4.);
//
h_trkAlgo_ =
iBooker.book1D("allTrackAlgo", " Track Algo ", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
h_trkAlgo_ = iBooker.book1D("allTrackAlgo",
" Track Algo ",
reco::TrackBase::algoSize,
-0.5,
static_cast<double>(reco::TrackBase::algoSize) - 0.5);
h_convAlgo_ = iBooker.book1D("allConvAlgo", " Conv Algo ", 5, -0.5, 4.5);
h_convQuality_ = iBooker.book1D("allConvQuality", "Conv quality ", 11, -0.5, 11.);

Expand Down