improve SiStripHitEffFromCalibTree and SiStripHitResolFromCalibTree

[mmusich]

PR description:

Somewhat inspired by cms-sw/cms-bot#2228, trying to debug crashes reported at cms-sw/cms-bot#2228 (comment), improve the modules SiStripHitEffFromCalibTree and SiStripHitResolFromCalibTree:

• close input calibTree files after reading them;
• delete all new-ly allocated memory;
• use named constants for k_END_OF_LAYERS and k_END_OF_LAYS_AND_RINGS in lieu of magic numbers

PR validation:

scram b runtests_testSiStripHitEfficiency and scram b runtests_testSiStripHitResolution run fine after the update.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to 14.0.X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45083/40403

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiStripHitEfficiency/test/testHitEffWorker.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)
• CalibTracker/SiStripHitResolution (alca)

@cmsbuild, @saumyaphor4252, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@rsreds, @echabert, @gbenelli, @tocheng, @yuanchao, @mmusich, @robervalwalsh this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e7715/39593/summary.html
COMMIT: 75a6c3d
CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45083/39593/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338833
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Why the objects in file are deleted and the files are written and closed only when the debug option is true?

[mmusich]

it was an (unsuccessful) attempt to debug #45084. AFAIU normally the destructor of TFileService should do that automatically, but somewhere there is a double deletion.
This piece could be removed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45083/40419

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiStripHitEfficiency/test/testHitEffWorker.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45083/40419/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45083/40419/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[antoniovilela]

ping (to make bot change milestone)

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.