Skip to content

BrokenLineFit and RiemannFit: mask asserts behind DEBUG flags #44801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Apr 23, 2024
Merged

BrokenLineFit and RiemannFit: mask asserts behind DEBUG flags #44801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,13 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
}
brokenline::fastFit(acc, hits, fast_fit);

// no NaN here....
ALPAKA_ASSERT_ACC(fast_fit(0) == fast_fit(0));
ALPAKA_ASSERT_ACC(fast_fit(1) == fast_fit(1));
ALPAKA_ASSERT_ACC(fast_fit(2) == fast_fit(2));
ALPAKA_ASSERT_ACC(fast_fit(3) == fast_fit(3));
#ifdef BROKENLINE_DEBUG
// any NaN value should cause the track to be rejected at a later stage
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(0)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(1)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(2)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(3)));
#endif
}
}
};
Expand Down
12 changes: 7 additions & 5 deletions RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,13 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
}
riemannFit::fastFit(acc, hits, fast_fit);

// no NaN here....
ALPAKA_ASSERT_ACC(fast_fit(0) == fast_fit(0));
ALPAKA_ASSERT_ACC(fast_fit(1) == fast_fit(1));
ALPAKA_ASSERT_ACC(fast_fit(2) == fast_fit(2));
ALPAKA_ASSERT_ACC(fast_fit(3) == fast_fit(3));
#ifdef RIEMANN_DEBUG
// any NaN value should cause the track to be rejected at a later stage
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(0)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(1)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(2)));
ALPAKA_ASSERT_ACC(not alpaka::math::isnan(acc, fast_fit(3)));
#endif
}
}
};
Expand Down