Skip to content

Conversation

@hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 9, 2024

PR description:

Fixes #44666.

PR validation:

Tested on 2500.323.

@hqucms
Copy link
Contributor Author

hqucms commented Apr 9, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Apr 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44672/39871

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • DPGAnalysis/L1TNanoAOD (xpog, l1)
  • PhysicsTools/NanoAOD (xpog)

@aloeliger, @hqucms, @vlimant, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2333d5/38708/summary.html
COMMIT: d270227
CMSSW: CMSSW_14_1_X_2024-04-09-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44672/38708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 67 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308887
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3308861
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 107 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16484
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16484
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 31 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.323-size.json
  • Nano ERROR: Missing ref/2500.323-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.574 | 2.574 | 0.000 ( +0.0% ) | 4.56 | 4.63 | -1.4% | 2.223 | 2.221 |
    | 2500.001 | 2.722 | 2.722 | 0.000 ( +0.0% ) | 4.11 | 4.13 | -0.4% | 2.628 | 2.638 |
    | 2500.002 | 2.667 | 2.667 | 0.000 ( +0.0% ) | 4.29 | 4.26 | +0.8% | 2.636 | 2.618 |
    | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 8.33 | 8.39 | -0.8% | 2.282 | 2.274 |
    | 2500.011 | 1.739 | 1.739 | 0.000 ( +0.0% ) | 4.63 | 4.60 | +0.8% | 2.433 | 2.409 |
    | 2500.012 | 1.580 | 1.580 | 0.000 ( +0.0% ) | 6.61 | 6.49 | +1.7% | 2.355 | 2.351 |
    | 2500.1 | 2.218 | 2.218 | 0.000 ( +0.0% ) | 4.57 | 4.63 | -1.3% | 2.059 | 2.065 |
    | 2500.2 | 2.333 | 2.333 | 0.000 ( +0.0% ) | 5.25 | 5.28 | -0.4% | 1.974 | 1.979 |
    | 2500.21 | 1.182 | 1.182 | 0.000 ( +0.0% ) | 3.52 | 3.54 | -0.5% | 2.254 | 2.266 |
    | 2500.211 | 1.546 | 1.546 | 0.000 ( +0.0% ) | 3.16 | 3.15 | +0.1% | 2.338 | 2.348 |
    | 2500.3 | 2.089 | 2.089 | 0.000 ( +0.0% ) | 10.28 | 10.23 | +0.5% | 1.919 | 1.966 |
    | 2500.301 | 2.667 | 2.667 | 0.000 ( +0.0% ) | 8.49 | 8.75 | -2.9% | 1.903 | 1.952 |
    | 2500.31 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.36 | 1.41 | -3.8% | 1.504 | 1.706 |
    | 2500.311 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.60 | 5.77 | +14.5% | 1.044 | 1.052 |
    | 2500.312 | 540.453 | 540.453 | 0.000 ( +0.0% ) | 0.53 | 0.53 | +0.3% | 1.414 | 1.592 |
    | 2500.313 | 817.689 | 817.689 | 0.000 ( +0.0% ) | 0.73 | 0.72 | +1.4% | 1.401 | 1.588 |
    | 2500.32 | 1.256 | 1.256 | 0.000 ( +0.0% ) | 13.00 | 13.09 | -0.7% | 2.346 | 2.344 |
    | 2500.321 | 1.643 | 1.643 | 0.000 ( +0.0% ) | 9.86 | 9.86 | -0.0% | 2.397 | 2.381 |
    | 2500.322 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 10.31 | 9.85 | +4.6% | 2.090 | 2.142 |
    | 2500.324 | 1.759 | 1.759 | 0.000 ( +0.0% ) | 10.14 | 10.22 | -0.8% | 2.176 | 2.294 |
    | 2500.325 | 4.144 | 4.144 | 0.000 ( +0.0% ) | 4.26 | 4.26 | +0.0% | 2.212 | 2.201 |
    | 2500.326 | 3.095 | 3.095 | 0.000 ( +0.0% ) | 1.80 | 1.82 | -1.6% | 2.075 | 1.932 |
    | 2500.327 | 1.791 | 1.791 | 0.000 ( +0.0% ) | 10.36 | 10.29 | +0.6% | 2.334 | 2.328 |
    | 2500.4 | 2.245 | 2.245 | 0.000 ( +0.0% ) | 9.75 | 9.75 | +0.1% | 1.854 | 1.832 |
    | 2500.401 | 1.778 | 1.778 | 0.000 ( +0.0% ) | 8.31 | 8.51 | -2.4% | 1.746 | 1.733 |
    | 2500.402 | 2.795 | 2.795 | 0.000 ( +0.0% ) | 8.48 | 8.40 | +0.9% | 1.905 | 1.748 |
    | 2500.403 | 8.752 | 8.752 | 0.000 ( +0.0% ) | 2.84 | 2.83 | +0.3% | 1.817 | 1.834 |
    | 2500.404 | 5.105 | 5.105 | 0.000 ( +0.0% ) | 1.34 | 1.33 | +0.6% | 1.776 | 1.763 |
    | 2500.405 | 2.803 | 2.803 | 0.000 ( +0.0% ) | 8.20 | 7.62 | +7.5% | 1.900 | 1.476 |
    | 2500.5 | 5.192 | 5.192 | 0.000 ( +0.0% ) | 15.79 | 16.01 | -1.4% | 1.568 | 1.566 |
    | 2500.51 | 9.119 | 9.119 | 0.000 ( +0.0% ) | 9.63 | 9.71 | -0.9% | 1.517 | 1.513 |

@hqucms
Copy link
Contributor Author

hqucms commented Apr 9, 2024

+1

@hqucms
Copy link
Contributor Author

hqucms commented Apr 9, 2024

@cms-sw/orp-l2 Could you please merge this soon? It's blocking a few nano-related PR tests.

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RelVal 2500.323: no function nanoL1TrigObjCustomizeFull

3 participants