Remove explicit SimHitCollection copy-constructor

[iarspider]

PR description:

Clang emits a warning:

  .../src/DataFormats/HGCalDigi/interface/PHGCSimAccumulator.h:53:5: warning: definition of implicit copy assignment operator for 'SimHitCollection' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]

PR validation:

Bot tests.

[iarspider]

please test for CMSSW_14_1_CLANG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44602/39784

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/HGCalDigi (upgrade, simulation)

@mdhildreth, @civanch, @subirsarkar, @srimanob can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/summary.html
COMMIT: 73ad3bd
CMSSW: CMSSW_14_1_CLANG_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44602/38577/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @dan131riley move DataRecord includes to HBHERecHitProducerGPU #44595
• @civanch [14_1_X SIM] Clean-up MC truth infrastructure #44593
• @riga Slight update to TensorFlowAOT interface. #44586

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38577/git-merge-result

Comparison Summary

Summary:

• You potentially added 11560 lines to the logs
• Reco comparison results: 31956 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3304819
• DQMHistoTests: Total failures: 54814
• DQMHistoTests: Total nulls: 181
• DQMHistoTests: Total successes: 3249804
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
• DQMHistoSizes: changed ( 141.042,... ): 0.004 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-359b8e/38608/summary.html
COMMIT: 73ad3bd
CMSSW: CMSSW_14_1_X_2024-04-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44602/38608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 98 lines to the logs
• Reco comparison results: 44 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3307717
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3307697
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1