[GCC13] Fix Woverloaded-virtual warning

[iarspider]

PR description:

This PR fixes overloaded-virtual warnings emitted by gcc13 link:

In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/Jet.h:4,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/HcalIsolatedTrack/interface/IsolatedPixelTrackCandidate.h:12,
                 from src/Alignment/OfflineValidation/plugins/EopElecTreeWriter.cc:39:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/L1Candidate.h:41:18: warning: 'virtual bool l1t::L1Candidate::operator==(const l1t::L1Candidate&) const' was hidden [-Woverloaded-virtual=]
    41 |     virtual bool operator==(const l1t::L1Candidate& rhs) const;
      |                  ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/Jet.h:42:18: note:   by 'virtual bool l1t::Jet::operator==(const l1t::Jet&) const'
   42 |     virtual bool operator==(const l1t::Jet& rhs) const;
      |                  ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/L1Candidate.h:42:25: warning: 'virtual bool l1t::L1Candidate::operator!=(const l1t::L1Candidate&) const' was hidden [-Woverloaded-virtual=]
    42 |     virtual inline bool operator!=(const l1t::L1Candidate& rhs) const { return !(operator==(rhs)); };
      |                         ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/Jet.h:43:25: note:   by 'virtual bool l1t::Jet::operator!=(const l1t::Jet&) const'
   43 |     virtual inline bool operator!=(const l1t::Jet& rhs) const { return !(operator==(rhs)); };
      |                         ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/L1Candidate.h:41:18: warning: 'virtual bool l1t::L1Candidate::operator==(const l1t::L1Candidate&) const' was hidden [-Woverloaded-virtual=]
    41 |     virtual bool operator==(const l1t::L1Candidate& rhs) const;
      |                  ^~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/HcalIsolatedTrack/interface/IsolatedPixelTrackCandidate.h:13:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/Tau.h:48:18: note:   by 'virtual bool l1t::Tau::operator==(const l1t::Tau&) const'
   48 |     virtual bool operator==(const l1t::Tau& rhs) const;
      |                  ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/L1Candidate.h:42:25: warning: 'virtual bool l1t::L1Candidate::operator!=(const l1t::L1Candidate&) const' was hidden [-Woverloaded-virtual=]
    42 |     virtual inline bool operator!=(const l1t::L1Candidate& rhs) const { return !(operator==(rhs)); };
      |                         ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f13f75b2cf04a5a6e5b5b92c5e0cd08a/opt/cmssw/el9_amd64_gcc13/cms/cmssw/CMSSW_14_1_X_2024-03-29-2300/src/DataFormats/L1Trigger/interface/Tau.h:49:25: note:   by 'virtual bool l1t::Tau::operator!=(const l1t::Tau&) const'
   49 |     virtual inline bool operator!=(const l1t::Tau& rhs) const { return !(operator==(rhs)); };
      |                         ^~~~~~~~

An alternative approach would be to make comparision operators in l1t::Tau etc non-virtual, since these look like final classes.

PR validation:

Bot tests

[iarspider]

please test for el9_amd64_gcc13

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44581/39747

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44581/39747/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44581/39747/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test for el9_amd64_gcc13

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44581/39748

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/L1Trigger (l1)

@epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@thomreis, @dinyar, @eyigitba, @kreczko, @missirol, @rovere this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38527/summary.html
COMMIT: 7c21c46
CMSSW: CMSSW_14_1_X_2024-03-29-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44581/38527/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cerminar Phase2 L1T, Correlator Layer-2 : support emulation of with TMUX18 input + GT interface tweaks #44346
• @Dr15Jones Added python type annotation to some configuration classes #44453
• @vlimant new Prompt Lepton ID MVA (and renaming) #44503
• @riga Enable TensorFlowAOT unit tests, remove dev workflow. #44519
• @iarspider [CLANG_X] Use generated copy ctor in FTLDataFrameT #44528
• @iarspider [CLANG_X] Use generated ctor in VertexProperty #44530
• @smorovic XGBoost producer bugfix and unit test fix for non-x86_64 (14_1_X) #44531
• @martinamalberti [MTD] Addition of mtd association maps to the event content #44548
• @felicepantaleo HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552
• @Dr15Jones Initialize cut parser earlier in NanoAODDQM module #44573

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38527/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38527/git-merge-result

Build

I found compilation error when building:

>> Building shared library tmp/el9_amd64_gcc13/src/PhysicsTools/TensorFlowAOT/src/PhysicsToolsTensorFlowAOT/libPhysicsToolsTensorFlowAOT.so
Copying tmp/el9_amd64_gcc13/src/PhysicsTools/TensorFlowAOT/src/PhysicsToolsTensorFlowAOT/libPhysicsToolsTensorFlowAOT.so to productstore area:
Leaving library rule at PhysicsTools/TensorFlowAOT
>> Compiling  src/PhysicsTools/TensorFlowAOT/test/testInterface.cc
>> Compiling  src/PhysicsTools/TensorFlowAOT/test/testRunner.cpp
src/PhysicsTools/TensorFlowAOT/test/testInterface.cc:10:10: fatal error: tfaot-model-test-simple/model.h: No such file or directory
   10 | #include "tfaot-model-test-simple/model.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
src/PhysicsTools/TensorFlowAOT/test/testInterface.cc:10:10: fatal error: tfaot-model-test-simple/model.h: No such file or directory
   10 | #include "tfaot-model-test-simple/model.h"


[iarspider]

please test for el9_amd64_gcc13

[smuzaffar]

please test

for gcc13, at least warnings in Alignment/OfflineValidation are fixed https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38527/build-logs/Alignment/OfflineValidation/log.html

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38532/summary.html
COMMIT: 7c21c46
CMSSW: CMSSW_14_1_X_2024-03-29-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44581/38532/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cerminar Phase2 L1T, Correlator Layer-2 : support emulation of with TMUX18 input + GT interface tweaks #44346
• @Dr15Jones Added python type annotation to some configuration classes #44453
• @vlimant new Prompt Lepton ID MVA (and renaming) #44503
• @riga Enable TensorFlowAOT unit tests, remove dev workflow. #44519
• @iarspider [CLANG_X] Use generated copy ctor in FTLDataFrameT #44528
• @iarspider [CLANG_X] Use generated ctor in VertexProperty #44530
• @smorovic XGBoost producer bugfix and unit test fix for non-x86_64 (14_1_X) #44531
• @martinamalberti [MTD] Addition of mtd association maps to the event content #44548
• @felicepantaleo HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552
• @Dr15Jones Initialize cut parser earlier in NanoAODDQM module #44573

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38532/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38532/git-merge-result

Build

I found compilation error when building:

>> Building shared library tmp/el9_amd64_gcc13/src/PhysicsTools/TensorFlowAOT/src/PhysicsToolsTensorFlowAOT/libPhysicsToolsTensorFlowAOT.so
Copying tmp/el9_amd64_gcc13/src/PhysicsTools/TensorFlowAOT/src/PhysicsToolsTensorFlowAOT/libPhysicsToolsTensorFlowAOT.so to productstore area:
Leaving library rule at PhysicsTools/TensorFlowAOT
>> Compiling  src/PhysicsTools/TensorFlowAOT/test/testInterface.cc
>> Compiling  src/PhysicsTools/TensorFlowAOT/test/testRunner.cpp
src/PhysicsTools/TensorFlowAOT/test/testInterface.cc:10:10: fatal error: tfaot-model-test-simple/model.h: No such file or directory
   10 | #include "tfaot-model-test-simple/model.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
src/PhysicsTools/TensorFlowAOT/test/testInterface.cc:10:10: fatal error: tfaot-model-test-simple/model.h: No such file or directory
   10 | #include "tfaot-model-test-simple/model.h"


[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/38538/summary.html
COMMIT: 7c21c46
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44581/38538/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 19 lines from the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297469
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297440
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44581/40131

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #44581 was updated. @tjavaid, @mdhildreth, @antoniovagnerini, @nothingface0, @syuvivida, @rvenditti, @civanch can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e109b7/39176/summary.html
COMMIT: 1f77ec0
CMSSW: CMSSW_14_1_X_2024-04-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44581/39176/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3326929
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3326906
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[tjavaid]

+1

• Do we need the label trk ?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

Do we need the label trk ?

it's automatically assigned based on the packages touched.

[rappoccio]

+1