Skip to content

[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Mar 26, 2024
Merged

[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b496190
[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation
iarspider Mar 25, 2024
96f3056
Update trackSplitPlot.C
iarspider Mar 25, 2024
b5fc309
Apply changes from review
iarspider Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/bin/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<flags CXXFLAGS="-g -Wall -O3 -Wall -std=c++17 -lASImage -lMultiProc" />
<flags CXXFLAGS="-Wall -O3 -Wall -lASImage -lMultiProc" />
Copy link
Contributor

@mmusich mmusich Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the the debug symbols (and remove the duplicated -Wall).

<use name="Alignment/OfflineValidation"/>
<use name="boost" />
<use name="boost_filesystem"/>
Expand Down
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/macros/trackSplitPlot.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ TCanvas *trackSplitPlot(Int_t nFiles,
setAxisLabels(p[i], type, xvar, yvar, relative, pull);
}

if (type == Histogram && !pull && any_of(begin(used), end(used), identity<bool>)) {
if (type == Histogram && !pull && any_of(begin(used), end(used), ::identity<bool>)) {
if (legendOptions.Contains("mean")) {
summaryfile << " mu_Delta" << yvar;
if (relative)
Expand Down