[CPP20][DQM] Replace some enums with constexpr ints

[iarspider]

PR description:

Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44487 following @makortel's suggestion.

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39639

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/CTPPS/plugins/TotemT2DQMSource.cc modified in PR(s): [CPP20][DQM] Remove deprecated enum arithmetic #44487

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CondFormats/EcalObjects (db, alca)
• DQM/CTPPS (dqm)
• DQM/EcalCommon (dqm)
• DataFormats/CTPPSReco (reconstruction)
• DataFormats/EcalDetId (simulation)

@jfernan2, @syuvivida, @francescobrivio, @tjavaid, @mandrenguyen, @saumyaphor4252, @nothingface0, @perrotta, @cmsbuild, @civanch, @mdhildreth, @consuegs, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@wang0jin, @rovere, @yuanchao, @grzanka, @thomreis, @argiro, @ReyerBand, @tocheng, @fabferro, @rsreds, @mmusich, @seemasharmafnal, @PonIlya, @JanChyczynski, @rchatter, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39644

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/CTPPS/plugins/TotemT2DQMSource.cc modified in PR(s): [CPP20][DQM] Remove deprecated enum arithmetic #44487

[cmsbuild]

Pull request #44515 was updated. @tjavaid, @perrotta, @antoniovagnerini, @cmsbuild, @francescobrivio, @nothingface0, @syuvivida, @consuegs, @mdhildreth, @mandrenguyen, @jfernan2, @saumyaphor4252, @civanch, @rvenditti can you please check and sign again.

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39742

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #44515 was updated. @antoniovagnerini, @syuvivida, @nothingface0, @civanch, @mdhildreth, @tjavaid, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f57598/38513/summary.html
COMMIT: d7fe83e
CMSSW: CMSSW_14_1_X_2024-03-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44515/38513/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 59 lines from the logs
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297469
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297449
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[iarspider]

@cms-sw/dqm-l2 gentle ping

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1