[WIP] [CPP20] Fix deprecated enum arithmetics

[iarspider]

PR description:

In C++20, arithmetic and comparision operations between different enums, and between floating-point types and enum are deprecated:

src/DQM/CTPPS/plugins/TotemT2DQMSource.cc: In member function 'void TotemT2DQMSource::fillFlags(const TotemT2Digi&, const TotemT2DetId&)':
  src/DQM/CTPPS/plugins/TotemT2DQMSource.cc:381:47: warning: arithmetic between enumeration type 'TotemT2DQMSource::evFlag' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
   381 |     sectorPlots_[secId].eventFlags->Fill(t2TE + 0.0);
      |                                          ~~~~~^~~~~
<...>
src/DQM/CTPPS/plugins/TotemTimingDQMSource.cc: In member function 'virtual void TotemTimingDQMSource::analyze(const edm::Event&, const edm::EventSetup&)':
  src/DQM/CTPPS/plugins/TotemTimingDQMSource.cc:622:27: warning: comparison of floating-point type 'float' with enumeration type 'TotemTimingRecHit::<unnamed enum>' is deprecated [-Wdeprecated-enum-float-conversion]
   622 |         if (rechit.time() != TotemTimingRecHit::NO_T_AVAILABLE) {
      |             ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DQM/CTPPS/plugins/TotemTimingDQMSource.cc:679:25: warning: comparison of floating-point type 'float' with enumeration type 'TotemTimingRecHit::<unnamed enum>' is deprecated [-Wdeprecated-enum-float-conversion]
   679 |       if (rechit.time() != TotemTimingRecHit::NO_T_AVAILABLE && potPlots_.find(detId_pot) != potPlots_.end() &&
      |           ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39553

• This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39553/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39553/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39566

• This PR adds an extra 68KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CalibFormats/SiStripObjects (alca)
• Calibration/EcalCalibAlgos (alca)
• CondCore/EcalPlugins (db)
• CondCore/PCLConfigPlugins (db)
• CondFormats/PCLConfig (alca, db)
• DPGAnalysis/SiStripTools (analysis)
• DQM/CTPPS (dqm)
• Geometry/CaloEventSetup (geometry)

@nothingface0, @mdhildreth, @saumyaphor4252, @tvami, @cmsbuild, @antoniovagnerini, @francescobrivio, @bsunanda, @Dr15Jones, @tjavaid, @consuegs, @perrotta, @rvenditti, @makortel, @civanch, @syuvivida can you please review it and eventually sign? Thanks.
@mtosi, @thomreis, @jandrea, @wang0jin, @mmusich, @VinInn, @rsreds, @robervalwalsh, @rchatter, @venturia, @PonIlya, @bsunanda, @JanChyczynski, @fabiocos, @argiro, @seemasharmafnal, @yuanchao, @fabferro, @tocheng, @grzanka, @echabert, @JanFSchulte, @ReyerBand, @VourMa, @threus this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39569

• This PR adds an extra 304KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/src/JetId.cc modified in PR(s): Update of the Phase-2 GMT Emulator #44319

[cmsbuild]

Pull request #44469 was updated. @consuegs, @subirsarkar, @bsunanda, @Dr15Jones, @srimanob, @nothingface0, @tjavaid, @francescobrivio, @civanch, @cmsbuild, @jfernan2, @mdhildreth, @aloeliger, @makortel, @perrotta, @mandrenguyen, @saumyaphor4252, @rvenditti, @syuvivida, @antoniovagnerini, @epalencia, @tvami can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39571

• This PR adds an extra 268KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/src/JetId.cc modified in PR(s): Update of the Phase-2 GMT Emulator #44319

[cmsbuild]

Pull request #44469 was updated. @civanch, @nothingface0, @jfernan2, @rvenditti, @syuvivida, @bsunanda, @tvami, @mdhildreth, @Dr15Jones, @francescobrivio, @cmsbuild, @epalencia, @makortel, @antoniovagnerini, @mandrenguyen, @tjavaid, @perrotta, @srimanob, @aloeliger, @consuegs, @saumyaphor4252, @subirsarkar can you please check and sign again.

[iarspider]

I think it's better to split it into several PRs.

[makortel]

I think the alternative approach of converting enums to constexpr constants should be considered too (where it makes sense).