Refactor scatterer addition in aGblPoint to explicitly specify type for scatPrecision.inverse()

[mmusich]

PR description:

To test with cms-sw/cmsdist#9053

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• pull_request = Update gbl to V03-01-01 and millepede to V04-16-00 cmsdist#9053
• addpkg = Alignment/TrackerAlignment, Alignment/OfflineValidation
• workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.4

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44340/39376

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• Alignment/ReferenceTrajectories (alca)

@saumyaphor4252, @consuegs, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37962/summary.html
COMMIT: 170814a
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44340/37962/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @BenjaminRS E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN  #44315
• @robervalwalsh MSSM Hbb trigger dqm updates for 2024 triggers [14_1_X] #44284
• @mandrenguyen Remove hanging references to ReconstructionHeavyIons #44329
• @slava77 add non-empty checks in DAClusterizer to avoid reading null refs #44281
• @dsidirop1 Updated btags and Working Points for Top Production mini AOD DQM  #44299
• @gkaratha Triplet emulator 14 0 0 pre3 #43998
• @archiron Validation/RecoEgamma PHASE2 histos filling correction V1 #44088
• @fwyzard Update ROCm to version 5.6.1 cmsdist#9050
• @cms-sw Update tag for L1Trigger-VertexFinder to V00-01-00 cmsdist#9054
• @cms-sw Update tag for L1Trigger-L1TTrackMatch to V00-01-00 cmsdist#9055

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37962/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37962/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test Zmumuall had ERRORS

RelVals

• 136.7611DAS Error
• 136.8311DAS Error

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37991/summary.html
COMMIT: 170814a
CMSSW: CMSSW_14_1_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44340/37991/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @tvami Add Phase-2 T33 SIM LA payload #44350
• @bsunanda Phase2-hgx354A Attempt to make xml files for cassette tests from an overall silicon wafer flat file of HGCal #44327
• @rbhattacharya04 2 New Trigger bits for Muon POG NanoAOD #44345

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37991/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9986c2/37991/git-merge-result

Comparison Summary

Summary:

• You potentially removed 88 lines from the logs
• Reco comparison results: 56 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3409724
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3408352
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 222 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[sroychow]

@cms-sw/externals-l2 @cms-sw/orp-l2 @cms-sw/alca-l2 following the discussion in comment, can this be reviewed and merged for the next IB?
Along with the external PR - cms-sw/cmsdist#9053

[tvami]

urgent

[perrotta]

+alca

• Add explicit type definition as required by the spec updates in the gbl and millepede externals
• It must be merged together with Update gbl to V03-01-01 and millepede to V04-16-00 cmsdist#9053 (well, probably it can even get merged alone... but the real update in the cmsdist PR)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9053

[antoniovilela]

+1