Implemented new modifiers for mvaTTH Run 3 #44322
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| run3_muon=cms.Modifier() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,39 +86,76 @@ | |
| cut = cms.string("pt > 3 && track.isNonnull && isLooseMuon") | ||
| ) | ||
|
|
||
| muonPROMPTMVA= cms.EDProducer("MuonBaseMVAValueMapProducer", | ||
| src = cms.InputTag("linkedObjects","muons"), | ||
| weightFile = cms.FileInPath("PhysicsTools/NanoAOD/data/mu_BDTG_2022.weights.xml"), | ||
| name = cms.string("muonPROMPTMVA"), | ||
| isClassifier = cms.bool(True), | ||
| variablesOrder = cms.vstring(["LepGood_pt","LepGood_eta","LepGood_pfRelIso03_all","LepGood_miniRelIsoCharged","LepGood_miniRelIsoNeutral","LepGood_jetNDauChargedMVASel","LepGood_jetPtRelv2","LepGood_jetDF","LepGood_jetPtRatio","LepGood_sip3d","LepGood_dxy","LepGood_dz","LepGood_segmentComp"]), | ||
| variables = cms.PSet( | ||
| LepGood_pt = cms.string("pt"), | ||
| LepGood_eta = cms.string("eta"), | ||
| LepGood_pfRelIso03_all = cms.string("(pfIsolationR03().sumChargedHadronPt + max(pfIsolationR03().sumNeutralHadronEt + pfIsolationR03().sumPhotonEt - pfIsolationR03().sumPUPt/2,0.0))/pt"), | ||
| LepGood_miniRelIsoCharged = cms.string("userFloat('miniIsoChg')/pt"), | ||
| LepGood_miniRelIsoNeutral = cms.string("(userFloat('miniIsoAll')-userFloat('miniIsoChg'))/pt"), | ||
| LepGood_jetNDauChargedMVASel = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('jetNDauChargedMVASel'):0"), | ||
| LepGood_jetPtRelv2 = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('ptRel'):0"), | ||
| LepGood_jetDF = cms.string("?userCand('jetForLepJetVar').isNonnull()?max(userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probbb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:problepb'),0.0):0.0"), | ||
| LepGood_jetPtRatio = cms.string("?userCand('jetForLepJetVar').isNonnull()?min(userFloat('ptRatio'),1.5):1.0/(1.0+(pfIsolationR04().sumChargedHadronPt + max(pfIsolationR04().sumNeutralHadronEt + pfIsolationR04().sumPhotonEt - pfIsolationR04().sumPUPt/2,0.0))/pt)"), | ||
| LepGood_sip3d = cms.string("abs(dB('PV3D')/edB('PV3D'))"), | ||
| LepGood_dxy = cms.string("log(abs(dB('PV2D')))"), | ||
| LepGood_dz = cms.string("log(abs(dB('PVDZ')))"), | ||
| LepGood_segmentComp = cms.string("segmentCompatibility"), | ||
|
|
||
| ) | ||
| ) | ||
|
|
||
| muonMVALowPt = muonPROMPTMVA.clone( | ||
| weightFile = cms.FileInPath("PhysicsTools/NanoAOD/data/mu_BDTG_lowpt.weights.xml"), | ||
| name = cms.string("muonMVALowPt"), | ||
| variablesOrder = cms.vstring(["LepGood_pt","LepGood_eta","LepGood_jetNDauChargedMVASel","LepGood_miniRelIsoCharged","LepGood_miniRelIsoNeutral","LepGood_jetPtRelv2","LepGood_jetDF","LepGood_jetPtRatio","LepGood_dxy","LepGood_sip3d","LepGood_dz","LepGood_segmentComp"]), | ||
|
Contributor
There was a problem hiding this comment. how about writing the
Contributor
Author
There was a problem hiding this comment. You mean to add this inside the
Contributor
There was a problem hiding this comment. hard to write down what I meant ; in essence with the least re-writing of the same string is preferred. please note #44392 that I created in a view to streamline that module configuration
Contributor
Author
There was a problem hiding this comment. I'm still not sure how to properly do this, although I get the idea and I think it looks better if we simplify it. I have two questions:
|
||
| variables = cms.PSet( | ||
| LepGood_pt = cms.string("pt"), | ||
| LepGood_eta = cms.string("eta"), | ||
| LepGood_jetNDauChargedMVASel = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('jetNDauChargedMVASel'):0"), | ||
| LepGood_miniRelIsoCharged = cms.string("userFloat('miniIsoChg')/pt"), | ||
| LepGood_miniRelIsoNeutral = cms.string("(userFloat('miniIsoAll')-userFloat('miniIsoChg'))/pt"), | ||
| LepGood_jetPtRelv2 = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('ptRel'):0"), | ||
| LepGood_jetDF = cms.string("?userCand('jetForLepJetVar').isNonnull()?max(userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probbb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:problepb'),0.0):0.0"), | ||
| LepGood_jetPtRatio = cms.string("?userCand('jetForLepJetVar').isNonnull()?min(userFloat('ptRatio'),1.5):1.0/(1.0+(pfIsolationR04().sumChargedHadronPt + max(pfIsolationR04().sumNeutralHadronEt + pfIsolationR04().sumPhotonEt - pfIsolationR04().sumPUPt/2,0.0))/pt)"), | ||
| LepGood_dxy = cms.string("log(abs(dB('PV2D')))"), | ||
| LepGood_sip3d = cms.string("abs(dB('PV3D')/edB('PV3D'))"), | ||
| LepGood_dz = cms.string("log(abs(dB('PVDZ')))"), | ||
| LepGood_segmentComp = cms.string("segmentCompatibility"), | ||
| ) | ||
| ) | ||
|
|
||
| run2_muon_2016.toModify( | ||
| muonPROMPTMVA, | ||
| weightFile = "PhysicsTools/NanoAOD/data/mu_BDTG_2016.weights.xml", | ||
| ) | ||
|
Comment on lines
133
to
136
Contributor
There was a problem hiding this comment. Given the
Contributor
There was a problem hiding this comment. In the present setup this |
||
|
|
||
| (run2_muon_2017 | run2_muon_2018).toModify( | ||
| muonPROMPTMVA, | ||
| weightFile = cms.FileInPath("PhysicsTools/NanoAOD/data/mu_BDTG_2017.weights.xml"), | ||
| variablesOrder = cms.vstring(["LepGood_pt","LepGood_eta","LepGood_jetNDauChargedMVASel","LepGood_miniRelIsoCharged","LepGood_miniRelIsoNeutral","LepGood_jetPtRelv2","LepGood_jetDF","LepGood_jetPtRatio","LepGood_dxy","LepGood_sip3d","LepGood_dz","LepGood_segmentComp"]), | ||
| variables = cms.PSet( | ||
| LepGood_pt = cms.string("pt"), | ||
| LepGood_eta = cms.string("eta"), | ||
| LepGood_jetNDauChargedMVASel = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('jetNDauChargedMVASel'):0"), | ||
| LepGood_miniRelIsoCharged = cms.string("userFloat('miniIsoChg')/pt"), | ||
| LepGood_miniRelIsoNeutral = cms.string("(userFloat('miniIsoAll')-userFloat('miniIsoChg'))/pt"), | ||
| LepGood_jetPtRelv2 = cms.string("?userCand('jetForLepJetVar').isNonnull()?userFloat('ptRel'):0"), | ||
| LepGood_jetDF = cms.string("?userCand('jetForLepJetVar').isNonnull()?max(userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probbb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:probb')+userCand('jetForLepJetVar').bDiscriminator('pfDeepFlavourJetTags:problepb'),0.0):0.0"), | ||
| LepGood_jetPtRatio = cms.string("?userCand('jetForLepJetVar').isNonnull()?min(userFloat('ptRatio'),1.5):1.0/(1.0+(pfIsolationR04().sumChargedHadronPt + max(pfIsolationR04().sumNeutralHadronEt + pfIsolationR04().sumPhotonEt - pfIsolationR04().sumPUPt/2,0.0))/pt)"), | ||
| LepGood_dxy = cms.string("log(abs(dB('PV2D')))"), | ||
| LepGood_sip3d = cms.string("abs(dB('PV3D')/edB('PV3D'))"), | ||
| LepGood_dz = cms.string("log(abs(dB('PVDZ')))"), | ||
| LepGood_segmentComp = cms.string("segmentCompatibility"), | ||
|
|
||
| ) | ||
| ) | ||
|
|
||
| from TrackingTools.TransientTrack.TransientTrackBuilder_cfi import * | ||
| muonBSConstrain = cms.EDProducer("MuonBeamspotConstraintValueMapProducer", | ||
| src = cms.InputTag("linkedObjects","muons"), | ||
|
|
@@ -178,7 +215,7 @@ | |
| jetNDauCharged = Var("?userCand('jetForLepJetVar').isNonnull()?userFloat('jetNDauChargedMVASel'):0", "uint8", doc="number of charged daughters of the closest jet"), | ||
| ), | ||
| externalVariables = cms.PSet( | ||
| promptMVA = ExtVar(cms.InputTag("muonPROMPTMVA"),float, doc="Prompt MVA lepton ID score. Corresponds to the previous mvaTTH",precision=14), | ||
| mvaLowPt = ExtVar(cms.InputTag("muonMVALowPt"),float, doc="Low pt muon ID score",precision=14), | ||
| fsrPhotonIdx = ExtVar(cms.InputTag("leptonFSRphotons:muFsrIndex"), "int16", doc="Index of the lowest-dR/ET2 among associated FSR photons"), | ||
| bsConstrainedPt = ExtVar(cms.InputTag("muonBSConstrain:muonBSConstrainedPt"),float, doc="pT with beamspot constraint",precision=-1), | ||
|
|
@@ -224,5 +261,5 @@ | |
|
|
||
| muonTask = cms.Task(slimmedMuonsUpdated,isoForMu,ptRatioRelForMu,slimmedMuonsWithUserData,finalMuons,finalLooseMuons ) | ||
| muonMCTask = cms.Task(muonsMCMatchForTable,muonMCTable) | ||
| muonTablesTask = cms.Task(muonPROMPTMVA,muonMVALowPt,muonBSConstrain,muonTable,muonMVAID) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still needed in the current implementation ? I don't think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this comment, run3_muon is actually useful. So I'd be inclined to keep it.