Skip to content

Conversation

@forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 29, 2024

PR description:

This PR introduces an interface to the CepGen central exclusive processes event generator described in Comput. Phys. Commun. 271 (2022), and introduced at a CMS-PH generator meeting last October.

It is shipped with generator fragments for a LPAIR and a PPtoFF single-dissociative generation. The earlier also demonstrates the interfacing of Pythia 6 for the fragmentation of dissociative beam remnants into a hadronic shower.

Requires CepGen v1.2.0+, added to cmsdist for 10_6_X releases in cms-sw/cmsdist#9042.

PR validation:

Shipped in generator fragments seem to be producing something consistent.

cmsDriver.py Configuration/Generator/python/CepGen_pptoff_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec
cmsDriver.py Configuration/Generator/python/CepGen_LPAIR_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44072 for UL MC campaigns

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for CMSSW_10_6_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/CepGenInterface (generators)

@mkirsano, @cmsbuild, @GurpreetSinghChahal, @menglu21, @bbilin, @SiewYan, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano, @fabiocos, @missirol, @alberto-sanchez, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

cms-bot internal usage

@bbilin
Copy link
Contributor

bbilin commented Feb 29, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8356/37821/summary.html
COMMIT: 081d07c
CMSSW: CMSSW_10_6_X_2024-02-25-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44268/37821/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Entering Package GeneratorInterface/CepGenInterface
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:8:0,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:5:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:11:10: fatal error: CepGen/Generator.h: No such file or directory
 #include 
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake: *** [tmp/slc7_amd64_gcc700/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/CepGenGeneratorFilter.cc.o] Error 1
>> Building edm plugin tmp/slc7_amd64_gcc700/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/libGeneratorInterfaceCepGenGenerator.so


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... done
****WARNING: Invalid tool CepGen. Please fix src/GeneratorInterface/CepGenInterface/BuildFile.xml file.
>> Creating project symlinks
>> Entering Package GeneratorInterface/CepGenInterface
>> Compile sequence completed for CMSSW CMSSW_10_6_X_2024-02-25-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Reading cached build data
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc 


@forthommel
Copy link
Contributor Author

forthommel commented Feb 29, 2024

@bbilin, probably you meant @cmsbuild please test with cms-sw/cmsdist#9042

@menglu21
Copy link
Contributor

menglu21 commented Mar 5, 2024

please test with cms-sw/cmsdist#9042

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8356/37893/summary.html
COMMIT: 081d07c
CMSSW: CMSSW_10_6_X_2024-03-03-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44268/37893/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/py2-pip/9.0.3-pafccj/lib/python3.6/site-packages/pip/req/req_install.py", line 439, in run_egg_info
command_desc='python setup.py egg_info')
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/py2-pip/9.0.3-pafccj/lib/python3.6/site-packages/pip/utils/__init__.py", line 707, in call_subprocess
% (command_desc, proc.returncode, cwd))
pip.exceptions.InstallationError: Command "python setup.py egg_info" failed with error code 1 in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/py2-onnx/1.5.0-9cb526bd2cf2108e053e12a54e7cd345/cmsdist-tmp/pip-3hf_p6pg-build/
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.iPrOBW (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.iPrOBW (%build)



@menglu21
Copy link
Contributor

menglu21 commented Mar 6, 2024

@bbilin, probably you meant @cmsbuild please test with cms-sw/cmsdist#9045

Hi @forthommel cms-sw/cmsdist#9045 is closed and cms-sw/cmsdist#9042 is needed, right?

@forthommel
Copy link
Contributor Author

Hi @menglu21! Yes indeed, I updated the comment when switching from the gcc700 to the gcc820 branch, but this is indeed meant to be merged along with cms-sw/cmsdist#9042.

@menglu21
Copy link
Contributor

Hi @rappoccio, @antoniovilela, @sextonkennedy is this error related to the CepGen package

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 12, 2024

test parameters:

@smuzaffar
Copy link
Contributor

please test

Along with the "generator filter" implementation linking everything together, this contains
generator fragments for a LPAIR and a PPtoFF single-dissociative generation.
The PPtoFF fragment also demonstrates the capability to use Pythia 6 for the fragmentation
of the dissociative beam remnants.

Requires CepGen v1.2.1patch1 at least.
@cmsbuild
Copy link
Contributor

Pull request #44268 was updated. @SiewYan, @cmsbuild, @mkirsano, @GurpreetSinghChahal, @alberto-sanchez, @menglu21, @bbilin can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #44268 was updated. @alberto-sanchez, @SiewYan, @mkirsano, @cmsbuild, @bbilin, @GurpreetSinghChahal, @menglu21 can you please check and sign again.

@forthommel
Copy link
Contributor Author

FYI @smuzaffar

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8356/38119/summary.html
COMMIT: 8e13c9e
CMSSW: CMSSW_10_6_X_2024-03-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44268/38119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9042

@forthommel
Copy link
Contributor Author

@rappoccio, @sextonkennedy, @antoniovilela I confirm that these two are supposed to be merged together (i.e. #44268 cannot build without cms-sw/cmsdist#9042)

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmsdist#9042, please check if they should be merged together

@forthommel
Copy link
Contributor Author

As for #44072, #44270, and #44269, if I may give a hand to ease the review process of this backport, @rappoccio, @sextonkennedy, @antoniovilela !

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 796f61a into cms-sw:CMSSW_10_6_X Mar 18, 2024
@forthommel forthommel deleted the cepgen_integration-10_6_X branch March 18, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants