[ROOT6] RNTuple API change: RNTupleWriter is private #43949

smuzaffar · 2024-02-13T07:22:49Z

RNTupleWriter(std::unique_ptr model, std::unique_ptrDetail::RPageSink sink); is private now (see jblomer/root@cac8467). This PR proposes to use new CreateRNTupleWriter. This change is needed to integrate the latest ROOT master changes in ROOT6 IBs ( cms-sw/cmsdist#8999 )

smuzaffar · 2024-02-13T07:23:04Z

enable nano

smuzaffar · 2024-02-13T07:23:08Z

please test

cmsbuild · 2024-02-13T07:23:13Z

cms-bot internal usage

cmsbuild · 2024-02-13T07:28:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43949/38821

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-13T07:28:34Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-02-13T15:22:11Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03bb41/37400/summary.html
COMMIT: 2696105
CMSSW: CMSSW_14_1_X_2024-02-12-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43949/37400/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 82 lines to the logs
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248526
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16524
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16524
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.545	2.545	0.000 ( +0.0% )	5.25	5.11	+2.8%	2.141	2.151
2500.001	2.692	2.692	0.000 ( +0.0% )	4.67	4.73	-1.3%	2.530	2.585
2500.002	2.631	2.631	0.000 ( +0.0% )	4.88	4.87	+0.3%	2.518	2.564
2500.01	1.315	1.315	0.000 ( +0.0% )	9.46	9.64	-1.8%	2.219	2.259
2500.011	1.732	1.732	0.000 ( +0.0% )	5.12	5.25	-2.4%	2.359	2.419
2500.012	1.578	1.578	0.000 ( +0.0% )	7.34	7.37	-0.4%	2.345	2.345
2500.1	2.193	2.193	0.000 ( +0.0% )	5.28	5.32	-0.7%	2.052	2.047
2500.2	2.307	2.307	0.000 ( +0.0% )	6.05	6.06	-0.1%	1.867	1.878
2500.21	1.183	1.183	0.000 ( +0.0% )	4.31	4.38	-1.5%	2.151	2.243
2500.211	1.547	1.547	0.000 ( +0.0% )	3.71	3.80	-2.5%	2.207	2.317
2500.3	2.063	2.063	0.000 ( +0.0% )	12.50	12.67	-1.4%	1.946	1.947
2500.31	1.258	1.258	0.000 ( +0.0% )	19.67	19.99	-1.6%	2.325	2.330
2500.311	1.646	1.646	0.000 ( +0.0% )	13.16	13.52	-2.7%	2.311	2.424
2500.312	7.159	7.159	0.000 ( +0.0% )	1.33	1.43	-6.7%	1.674	1.671
2500.313	1.564	1.564	0.000 ( +0.0% )	6.96	6.77	+2.8%	1.030	1.032
2500.4	2.063	2.063	0.000 ( +0.0% )	12.35	12.70	-2.7%	1.945	1.949
2500.5	19.575	19.575	0.000 ( +0.0% )	1.07	1.24	-13.6%	1.103	1.117

smuzaffar · 2024-02-13T15:41:44Z

@cms-sw/xpog-l2 , can you please review this. This is needed for ROOT master IBswhere RNTuple has more changes for its API

hqucms · 2024-02-13T15:59:05Z

+1

cmsbuild · 2024-02-13T15:59:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

makortel · 2024-02-13T16:23:08Z

FYI @dan131riley

cmsbuild · 2024-02-13T22:54:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03bb41/37400/summary.html
COMMIT: 2696105
CMSSW: CMSSW_14_1_X_2024-02-12-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43949/37400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 82 lines to the logs
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248526
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16524
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16524
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.545	2.545	0.000 ( +0.0% )	5.25	5.11	+2.8%	2.141	2.151
2500.001	2.692	2.692	0.000 ( +0.0% )	4.67	4.73	-1.3%	2.530	2.585
2500.002	2.631	2.631	0.000 ( +0.0% )	4.88	4.87	+0.3%	2.518	2.564
2500.01	1.315	1.315	0.000 ( +0.0% )	9.46	9.64	-1.8%	2.219	2.259
2500.011	1.732	1.732	0.000 ( +0.0% )	5.12	5.25	-2.4%	2.359	2.419
2500.012	1.578	1.578	0.000 ( +0.0% )	7.34	7.37	-0.4%	2.345	2.345
2500.1	2.193	2.193	0.000 ( +0.0% )	5.28	5.32	-0.7%	2.052	2.047
2500.2	2.307	2.307	0.000 ( +0.0% )	6.05	6.06	-0.1%	1.867	1.878
2500.21	1.183	1.183	0.000 ( +0.0% )	4.31	4.38	-1.5%	2.151	2.243
2500.211	1.547	1.547	0.000 ( +0.0% )	3.71	3.80	-2.5%	2.207	2.317
2500.3	2.063	2.063	0.000 ( +0.0% )	12.50	12.67	-1.4%	1.946	1.947
2500.31	1.258	1.258	0.000 ( +0.0% )	19.67	19.99	-1.6%	2.325	2.330
2500.311	1.646	1.646	0.000 ( +0.0% )	13.16	13.52	-2.7%	2.311	2.424
2500.312	7.159	7.159	0.000 ( +0.0% )	1.33	1.43	-6.7%	1.674	1.671
2500.313	1.564	1.564	0.000 ( +0.0% )	6.96	6.77	+2.8%	1.030	1.032
2500.4	2.063	2.063	0.000 ( +0.0% )	12.35	12.70	-2.7%	1.945	1.949
2500.5	19.575	19.575	0.000 ( +0.0% )	1.07	1.24	-13.6%	1.103	1.117

vlimant · 2024-02-14T09:07:45Z

I cannot recall if we have a test workflow for this anywhere ; anyone ?

dan131riley · 2024-02-14T11:16:05Z

I cannot recall if we have a test workflow for this anywhere ; anyone ?

I don't believe we currently have test WF for the rntuple NANO writer. I'm working on some updates that should add one.

smuzaffar · 2024-02-14T11:51:06Z

@cms-sw/orp-l2 , can you merge this? This will allow to move forward with root master updates

smuzaffar · 2024-02-15T08:05:35Z

ping @cms-sw/orp-l2

dan131riley · 2024-02-16T14:09:04Z

ping @cms-sw/orp-l2 this is holding up development (that would include a test for the RNtuple NANO producer)

antoniovilela · 2024-02-18T06:37:06Z

+1

[ROOT6] RNTuple API change: RNTupleWriter is private

2696105

cmsbuild added this to the CMSSW_14_1_X milestone Feb 13, 2024

cmsbuild added pending-signatures orp-pending tests-started code-checks-pending xpog-pending labels Feb 13, 2024

smuzaffar mentioned this pull request Feb 13, 2024

[ROOTMaster] Updated root to tip of branch master cms-sw/cmsdist#8999

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 13, 2024

smuzaffar mentioned this pull request Feb 13, 2024

Backport jitlink ppc64 cms-sw/root#200

Closed

cmsbuild added tests-rejected and removed tests-started labels Feb 13, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 13, 2024

cmsbuild added tests-started and removed tests-rejected labels Feb 13, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 13, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 18, 2024

cmsbuild merged commit e2855ab into cms-sw:master Feb 18, 2024

cmsbuild mentioned this pull request Feb 18, 2024

Enable TF XLA, add tensorflow-xla-runtime. cms-sw/cmsdist#9005

Merged

[ROOT6] RNTuple API change: RNTupleWriter is private #43949

[ROOT6] RNTuple API change: RNTupleWriter is private #43949

Uh oh!

Conversation

smuzaffar commented Feb 13, 2024

Uh oh!

smuzaffar commented Feb 13, 2024

Uh oh!

smuzaffar commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024

RelVals-INPUT

Comparison Summary

NANO Comparison Summary

Uh oh!

smuzaffar commented Feb 13, 2024

Uh oh!

hqucms commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024

Uh oh!

makortel commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024

Comparison Summary

NANO Comparison Summary

Uh oh!

vlimant commented Feb 14, 2024

Uh oh!

dan131riley commented Feb 14, 2024

Uh oh!

smuzaffar commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Feb 15, 2024

Uh oh!

dan131riley commented Feb 16, 2024

Uh oh!

antoniovilela commented Feb 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Feb 13, 2024 •

edited

Loading

smuzaffar commented Feb 14, 2024 •

edited

Loading