Follow up to the Alpaka integration in CMSSW #43853

fwyzard · 2024-02-03T00:29:15Z

PR description:

`HeterogeneousCore/AlpakaInterface`

Rewrite the work division utilities:

rewrite the uniform element kernel loops.
rewrite the independent element kernel loops.
remove the obsolete alpakatools utilities.

Rewrite the zeroAndInit kernel using the alpakatools utilities.
Rename elements_with_stride to uniform_elements in user code.

`RecoLocalTracker/SiPixelClusterizer`

Implement fixes that were lost during the CUDA-to-Alpaka migration.

Collect the updates from #39711, #42618, #42977 and #43052, that were missing from the Alpaka implementation:

skip invalid or corrupted ROCs: make the Alpaka implementation of the pixel unpacker skip spurious ROCs, similar to the legacy and CUDA versions of the unpacker, and store the
invalid ROC number error (errorType=36);
fix the decoding of channels with timeout errors (errorType=27);
synchronise the treatment of pixel errorType=26, 27, 30 with the legacy code;
disable printf statements at compile time.

`RecoTracker/PixelSeeding`

Do not call the fishbone for events with pixel hits only in BPIX1 (reimplement #35638).

`RecoTracker/MeasurementDet`

Add a check on the pixel ROC range, to avoid overflows in the (unsigned) range differences.

`DataFormats/TrackingRecHitSoA`

Extend TrackingRecHits collections for testing and their unit tests.

`CondFormats/SiPixelObjects`

Clean up includes and dependencies, and avoid including framework headers in the device compilation.

`Geometry/CommonTopologies`

Update comments to pixel topologies.

Other changes

Fix include guards after files were moved to different packages.
Clean up include files.
Simplify nested namespace declarations.

PR validation:

Unit tests pass.

Validated running a recent HLT menu over 20k events without issues, both on GPU and on CPU, on data and MC: the alpaka implementation running on CPU or GPU gives the same results as the CUDA implementation, within the same non-reproducibility margins (1 event or up to 1% for high-rate triggers).

Backport status

The backport to CMSSW_14_0_X for 2024 data taking is in #43879.

cmsbuild · 2024-02-03T00:29:42Z

cms-bot internal usage

fwyzard · 2024-02-03T00:35:07Z

assign heterogeneous

cmsbuild · 2024-02-03T00:36:26Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43853/38691

ERROR: Build errors found during clang-tidy run.

RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc:636:41: error: expected '(' for function-style cast or type construction [clang-diagnostic-error]
  636 |                               CalibDigis<true>{},
      |                               ~~~~~~~~~~^
RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc:636:46: error: initializer list cannot be used on the right hand side of operator '>' [clang-diagnostic-error]
  636 |                               CalibDigis<true>{},
      |                                              ^~~
RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc:645:41: error: expected '(' for function-style cast or type construction [clang-diagnostic-error]
  645 |                               CalibDigis<false>{},
      |                               ~~~~~~~~~~^
RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc:645:47: error: initializer list cannot be used on the right hand side of operator '>' [clang-diagnostic-error]
  645 |                               CalibDigis<false>{},
      |                                               ^~~
Suppressed 571 warnings (571 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2024-02-03T00:38:34Z

test parameters:

enable = gpu
workflows = 12434.402,12434.403,12434.404
workflows_gpu = 12434.402,12434.403,12434.404
workflow_opts = -w upgrade
workflow_opts_gpu = -w upgrade

fwyzard · 2024-02-03T00:39:12Z

please test

cmsbuild · 2024-02-03T00:44:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43853/38692

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): Update Alpaka to version 1.1.0 #43772

cmsbuild · 2024-02-03T00:45:04Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2024-02-12T10:41:13Z

Pull request #43853 was updated. @jfernan2, @francescobrivio, @subirsarkar, @consuegs, @perrotta, @srimanob, @saumyaphor4252, @mandrenguyen can you please check and sign again.

srimanob · 2024-02-12T11:01:38Z

+Upgrade

perrotta · 2024-02-12T12:52:19Z

+alca

perrotta · 2024-02-12T12:52:24Z

+db

mandrenguyen · 2024-02-12T15:37:33Z

are the tests stuck?

smuzaffar · 2024-02-12T15:41:38Z

are the tests stuck?

No @mandrenguyen , tests are running. Jenkins is very busy today that is why tests are waiting for free nodes

cmsbuild · 2024-02-12T19:10:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536c0d/37363/summary.html
COMMIT: c7d3641
CMSSW: CMSSW_14_1_X_2024-02-12-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43853/37363/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 101 lines from the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3280699
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3280672
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 211 log files, 173 edm output root files, 50 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 70 differences found in the comparisons
DQMHistoTests: Total files compared: 5
DQMHistoTests: Total histograms compared: 71813
DQMHistoTests: Total failures: 2870
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 68943
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
Checked 19 log files, 22 edm output root files, 5 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-02-12T19:50:50Z

+1

cmsbuild · 2024-02-12T19:51:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-02-12T20:21:37Z

+1

Martin-Grunewald · 2024-02-13T07:41:54Z

@fwyzard
Is there a backport to 14_0 for this PR? Is it #43879 ?

fwyzard · 2024-02-13T09:19:30Z

Yes, #43879 .
I've updated the description with a link to it.

cmsbuild added this to the CMSSW_14_0_X milestone Feb 3, 2024

cmsbuild added reconstruction-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels Feb 3, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2024

cmsbuild added the heterogeneous-pending label Feb 3, 2024

cmsbuild added tests-pending code-checks-rejected and removed tests-started code-checks-pending labels Feb 3, 2024

fwyzard force-pushed the alpaka_integration_branch branch from 64e5704 to a884a4d Compare February 3, 2024 00:38

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 3, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2024

cmsbuild removed the code-checks-pending label Feb 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 12, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 12, 2024

cmsbuild added alca-approved db-approved and removed alca-pending db-pending labels Feb 12, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 12, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 12, 2024

cmsbuild merged commit 6e8031b into cms-sw:master Feb 12, 2024

fwyzard deleted the alpaka_integration_branch branch March 2, 2024 22:41

Follow up to the Alpaka integration in CMSSW #43853

Follow up to the Alpaka integration in CMSSW #43853

Uh oh!

Conversation

fwyzard commented Feb 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

HeterogeneousCore/AlpakaInterface

RecoLocalTracker/SiPixelClusterizer

RecoTracker/PixelSeeding

RecoTracker/MeasurementDet

DataFormats/TrackingRecHitSoA

CondFormats/SiPixelObjects

Geometry/CommonTopologies

Other changes

PR validation:

Backport status

Uh oh!

cmsbuild commented Feb 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 3, 2024

Uh oh!

fwyzard commented Feb 3, 2024

Uh oh!

fwyzard commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 12, 2024

Uh oh!

srimanob commented Feb 12, 2024

Uh oh!

perrotta commented Feb 12, 2024

Uh oh!

perrotta commented Feb 12, 2024

Uh oh!

mandrenguyen commented Feb 12, 2024

Uh oh!

smuzaffar commented Feb 12, 2024

Uh oh!

cmsbuild commented Feb 12, 2024

Comparison Summary

GPU Comparison Summary

Uh oh!

mandrenguyen commented Feb 12, 2024

Uh oh!

cmsbuild commented Feb 12, 2024

Uh oh!

antoniovilela commented Feb 12, 2024

Uh oh!

Martin-Grunewald commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

fwyzard commented Feb 3, 2024 •

edited

Loading

`HeterogeneousCore/AlpakaInterface`

`RecoLocalTracker/SiPixelClusterizer`

`RecoTracker/PixelSeeding`

`RecoTracker/MeasurementDet`

`DataFormats/TrackingRecHitSoA`

`CondFormats/SiPixelObjects`

`Geometry/CommonTopologies`

cmsbuild commented Feb 3, 2024 •

edited

Loading

Martin-Grunewald commented Feb 13, 2024 •

edited

Loading

fwyzard commented Feb 13, 2024 •

edited

Loading