Remove deprecated heavy-ion reconstruction #43824

mandrenguyen · 2024-01-31T13:18:31Z

The old version of the HI reco that was based on --scenario HeavyIons has not been used since 2015, and has since been supplanted by the era functionality.
This is a first attempt at cleaning up some old stuff that is causing maintenance issues.
It should be noted that we will no longer have a running workflows for heavy ion data from 2015 and earlier.

cmsbuild · 2024-01-31T13:18:59Z

cms-bot internal usage

cmsbuild · 2024-01-31T13:25:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43824/38639

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): re-organize workflows exercising the SiPixelAliHGCombined PCL workflow #43810

cmsbuild · 2024-01-31T13:25:50Z

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

Configuration/PyReleaseValidation (upgrade, pdmv)
RecoHI/Configuration (reconstruction)
RecoHI/HiEgammaAlgos (reconstruction)
RecoHI/HiJetAlgos (reconstruction)
RecoHI/HiMuonAlgos (reconstruction)
RecoHI/HiTracking (reconstruction)

@mandrenguyen, @sunilUIET, @subirsarkar, @cmsbuild, @miquork, @AdrianoDee, @jfernan2, @srimanob can you please review it and eventually sign? Thanks.
@yslai, @slomeo, @yenjie, @dgulhan, @missirol, @jazzitup, @Martin-Grunewald, @makortel, @kurtejung, @fabiocos, @MiheeJo, @yetkinyilmaz this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mandrenguyen · 2024-01-31T13:28:23Z

please test

cmsbuild · 2024-01-31T13:39:44Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40d8c0/37137/summary.html
COMMIT: 1f55aa2
CMSSW: CMSSW_14_0_X_2024-01-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43824/37137/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Entering library rule at src/RecoHI/HiTracking/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIBestVertexProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIBestVertexSelector.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIMultiTrackSelector.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIBestVertexProducer.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/poison/RecoHI/HiTracking/interface/HIBestVertexProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIPixelClusterVtxProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIPixelMedianVtxProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-31-1100/src/RecoHI/HiTracking/plugins/HIPixelTrackFilterProducer.cc

mandrenguyen · 2024-01-31T13:49:43Z

please test

cmsbuild · 2024-01-31T13:55:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43824/38640

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): re-organize workflows exercising the SiPixelAliHGCombined PCL workflow #43810

cmsbuild · 2024-02-29T18:45:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43824/39291

This PR adds an extra 72KB to repository
Found files with invalid states:
- RecoHI/HiTracking/python/HIBestVertexSequences_cff.py:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/plugins/HIBestVertexSelector.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/Configuration/python/RecoHI_EventContent_cff.py:
  - Deleted: 01c75db
  - Added: 4dfdc99
- RecoHI/HiTracking/plugins/HIPixelMedianVtxProducer.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiMuonAlgos/plugins/BuildFile.xml:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/interface/HIBestVertexProducer.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/plugins/HIProtoTrackFilterProducer.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiMuonAlgos/python/RecoHiMuon_EventContent_cff.py:
  - Deleted: 01c75db
  - Added: 4dfdc99
- RecoHI/HiTracking/plugins/HIPixelClusterVtxProducer.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/interface/BestVertexComparator.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiMuonAlgos/plugins/SealModule.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiMuonAlgos/plugins/HIMuonTrackingRegionProducer.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/plugins/HIPixelClusterVtxProducer.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/python/RecoHiTracker_EventContent_cff.py:
  - Deleted: 01c75db
  - Added: 4dfdc99
- RecoHI/HiJetAlgos/python/RecoHiJets_EventContent_cff.py:
  - Deleted: 01c75db
  - Added: 4dfdc99
- RecoHI/HiTracking/plugins/HIPixelMedianVtxProducer.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/interface/HIProtoTrackFilter.h:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/plugins/HIBestVertexProducer.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiTracking/src/HIProtoTrackFilter.cc:
  - Deleted: 01c75db
  - Added: b420ddc
- RecoHI/HiEgammaAlgos/python/RecoHiEgamma_EventContent_cff.py:
  - Deleted: 01c75db
  - Added: 4dfdc99
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_production.py modified in PR(s): TOoLLiP integration #43638
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): TOoLLiP integration #43638
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): TOoLLiP integration #43638, [PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044
- File RecoHI/Configuration/python/Reconstruction_hiPF_cff.py modified in PR(s): TOoLLiP integration #43638

mandrenguyen · 2024-03-01T09:47:15Z

Code-checks is running since yesterday, which seems odd. Is there an easy way to jumpstart it?

cmsbuild · 2024-03-01T09:47:38Z

Pull request #43824 was updated. @fabiocos, @antoniovilela, @rappoccio, @davidlange6, @srimanob, @subirsarkar, @jfernan2, @sunilUIET, @AdrianoDee, @mandrenguyen, @miquork can you please check and sign again.

cmsbuild · 2024-03-01T12:30:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40d8c0/37846/summary.html
COMMIT: 47ee613
CMSSW: CMSSW_14_1_X_2024-02-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43824/37846/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 84 lines to the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3289735
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3289712
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-03-03T12:48:07Z

+1

mandrenguyen · 2024-03-03T12:48:47Z

Gentle ping @cms-sw/pdmv-l2 @cms-sw/upgrade-l2

AdrianoDee · 2024-03-03T17:24:54Z

+pdmv
(re-sign)

srimanob · 2024-03-05T16:17:17Z

+Upgrade

antoniovilela · 2024-03-05T17:03:12Z

+1

cmsbuild · 2024-03-05T17:03:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

mandrenguyen marked this pull request as draft January 31, 2024 13:18

cmsbuild added this to the CMSSW_14_0_X milestone Jan 31, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending tracking labels Jan 31, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2024

cmsbuild added tests-rejected operations-pending tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Jan 31, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 1, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 3, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Mar 3, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 5, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Mar 5, 2024

cmsbuild merged commit 406161a into cms-sw:master Mar 5, 2024

fabiocos mentioned this pull request Mar 6, 2024

No module named 'Configuration.StandardSequences.ReconstructionHeavyIons_cff' #44326

Closed

cmsbuild mentioned this pull request Mar 9, 2024

Update to CUDA 12.4.0 cms-sw/cmsdist#9046

Merged

mandrenguyen mentioned this pull request Apr 9, 2024

remove deprecated heavyIon scenario workflows #44665

Merged

Remove deprecated heavy-ion reconstruction #43824

Remove deprecated heavy-ion reconstruction #43824

Uh oh!

Conversation

mandrenguyen commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 31, 2024

Uh oh!

cmsbuild commented Jan 31, 2024

Uh oh!

mandrenguyen commented Jan 31, 2024

Uh oh!

cmsbuild commented Jan 31, 2024

Build

Uh oh!

mandrenguyen commented Jan 31, 2024

Uh oh!

cmsbuild commented Jan 31, 2024

Uh oh!

cmsbuild commented Feb 29, 2024

Uh oh!

mandrenguyen commented Mar 1, 2024

Uh oh!

cmsbuild commented Mar 1, 2024

Uh oh!

cmsbuild commented Mar 1, 2024

Comparison Summary

Uh oh!

mandrenguyen commented Mar 3, 2024

Uh oh!

mandrenguyen commented Mar 3, 2024

Uh oh!

AdrianoDee commented Mar 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srimanob commented Mar 5, 2024

Uh oh!

antoniovilela commented Mar 5, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mandrenguyen commented Jan 31, 2024 •

edited

Loading

cmsbuild commented Jan 31, 2024 •

edited

Loading

AdrianoDee commented Mar 3, 2024 •

edited

Loading