Alternative options for creating a serial copy of alpaka modules #43803
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| def makeSerialClone(module, **kwargs): | ||
| type = module._TypedParameterizable__type | ||
| if type.endswith('@alpaka'): | ||
| # alpaka module with automatic backend selection | ||
| base = type.removesuffix('@alpaka') | ||
| elif type.startswith('alpaka_serial_sync::'): | ||
| # alpaka module with explicit serial_sync backend | ||
| base = type.removeprefix('alpaka_serial_sync::') | ||
|
Comment on lines
+6
to
+8
Contributor
There was a problem hiding this comment. The |
||
| elif type.startswith('alpaka_cuda_async::'): | ||
| # alpaka module with explicit cuda_async backend | ||
| base = type.removeprefix('alpaka_cuda_async::') | ||
| elif type.startswith('alpaka_rocm_async::'): | ||
| # alpaka module with explicit rocm_async backend | ||
| base = type.removeprefix('alpaka_rocm_async::') | ||
|
Comment on lines
+6
to
+14
Contributor
There was a problem hiding this comment. The if-else chain could be replaced with e.g. a regex to remove the |
||
| else: | ||
| # non-alpaka module | ||
| raise TypeError('%s is not an alpaka-based module, and cannot be used with makeSerialClone()' % str(module)) | ||
|
|
||
| copy = module.clone(**kwargs) | ||
| copy._TypedParameterizable__type = 'alpaka_serial_sync::' + base | ||
| if 'alpaka' in copy.parameterNames_(): | ||
| del copy.alpaka | ||
| return copy | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makortel what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is much better than spreading around the direct modification
copy._TypedParameterizable__type, and a reasonable way for immediate needs. For the longer term I'd still like to solve the problem in different way, with which I'll follow up in #43780