Clean up some unnecessary {begin,end}{Run,LuminosityBlock} transition functions

[makortel]

PR description:

This PR removes some empty or commented out {begin,end}{Run,LuminosityBlock} transition functions, destructors, or commented out functions that I came across while looking for stream modules that call {begin,end}LuminosityBlock() functions. Removing them makes future similar searches easier.

Resolves cms-sw/framework-team#764

PR validation:

Code compiles.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43648/38307

• This PR adds an extra 212KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/plugins/VertexTableProducer.cc modified in PR(s): Add PV sumPT2 of pf charged particles associated to PV in NanoAOD  #43487, Lepton time-life info for NanoAOD #43525

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• Alignment/MillePedeAlignmentAlgorithm (alca)
• CommonTools/RecoAlgos (reconstruction)
• DQM/HLTEvF (hlt, dqm)
• DQM/L1TMonitorClient (dqm)
• DQM/TrigXMonitorClient (dqm)
• DQMOffline/EGamma (dqm)
• DQMOffline/Trigger (dqm)
• EgammaAnalysis/ElectronTools (analysis)
• EventFilter/L1TRawToDigi (l1)
• EventFilter/L1TXRawToDigi (l1)
• EventFilter/Utilities (daq)
• HLTrigger/HLTfilters (hlt)
• HLTrigger/special (hlt)
• L1Trigger/L1TCaloLayer1 (l1)
• L1Trigger/L1TCalorimeter (l1)
• L1Trigger/L1TGlobal (l1)
• L1Trigger/L1TMuon (l1)
• L1Trigger/L1TMuonEndCap (l1)
• PhysicsTools/IsolationAlgos (reconstruction)
• PhysicsTools/JetMCAlgos (analysis)
• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (reconstruction, xpog)
• TauAnalysis/MCEmbeddingTools (simulation)

@vlimant, @smorovic, @jfernan2, @consuegs, @mdhildreth, @civanch, @Martin-Grunewald, @syuvivida, @cmsbuild, @saumyaphor4252, @tjavaid, @perrotta, @aloeliger, @epalencia, @hqucms, @mmusich, @emeschi, @nothingface0, @antoniovagnerini, @rvenditti, @tvami, @mandrenguyen can you please review it and eventually sign? Thanks.
@tlampen, @afiqaize, @jdamgov, @Senphy, @ram1123, @sameasy, @gkasieczka, @Martin-Grunewald, @varuns23, @ahinzmann, @JanFSchulte, @dinyar, @battibass, @rappoccio, @gpetruc, @hatakeyamak, @Ming-Yan, @andrzejnovak, @adewit, @rovere, @seemasharmafnal, @rociovilar, @schoef, @jainshilpi, @demuller, @cericeci, @missirol, @eyigitba, @jdolen, @Sam-Harper, @a-kapoor, @JyothsnaKomaragiri, @Fedespring, @mmarionncern, @mtosi, @thomreis, @mmusich, @mariadalfonso, @Prasant1993, @yuanchao, @emilbols, @sobhatta, @tocheng, @abbiendi, @azotz, @silviodonato, @gouskos, @jhgoh, @rsreds, @AnnikaStein, @HuguesBrun, @trocino, @nhanvtran, @AlexDeMoor, @mbluj this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[perrotta]

+alca

• Technical: it mostly removes already commented out or unused code

[civanch]

+1

[smorovic]

+1

[makortel]

@Dr15Jones

[aloeliger]

+l1

[vlimant]

+1

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1