Skip to content

Conversation

@fabiocos
Copy link
Contributor

PR description:

This PR adds a new BTL scenario V3 on top of the just integrated MTD scenario I17, added in #43407 . This new configuration, developed by @pauris123 , differs from V2 for the crystal thickness, set everywhere to 3.75 mm, as it will be in reality (purchase order ongoing). This is the opportunity to drop the crystal thickness from the geometry construction, and have 6 equal readout units along z.

The numbering scheme for the time being is just adapted to the existing BTLDetId, creating an effective crystal thickness index, so as to postpone the major update to the moment in which the BTL V1 can be finally dropped, allowing us to optimize the bit fields structure for a final configuration.

PR validation:

All basic geometry checks (when geometry scenario is adapted) look reasonable, and a complete workflow runs. No overlap is detected at ideal geometry level, and visual inspection in fireworks appears ok.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43553/38154

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2023

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • DataFormats/ForwardDetId (upgrade, simulation)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/MTDCommonData (upgrade, geometry)
  • Geometry/MTDGeometryBuilder (upgrade, geometry)
  • Geometry/MTDNumberingBuilder (upgrade, geometry)
  • Geometry/MTDSimData (upgrade, geometry)
  • RecoMTD/DetLayers (upgrade, reconstruction)

@Dr15Jones, @jfernan2, @mandrenguyen, @srimanob, @cmsbuild, @bsunanda, @subirsarkar, @makortel, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@vargasa, @Martin-Grunewald, @missirol, @bsunanda, @slomeo, @rovere, @youyingli, @apsallid this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 27634.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c99e72/36440/summary.html
COMMIT: 71bd324
CMSSW: CMSSW_14_0_X_2023-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43553/36440/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c99e72/36440/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c99e72/36440/git-merge-result

Comparison Summary

Summary:

@srimanob
Copy link
Contributor

+Upgrade

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Dec 13, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34f4fe8 into cms-sw:master Dec 14, 2023
@fabiocos fabiocos deleted the fc-BTL_v3 branch December 15, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants