-
Notifications
You must be signed in to change notification settings - Fork 4.6k
MTD geometry: add BTL V3 (one crystal thickness only) to MTD scenario I17 (global scenario D105) #43553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y BTL numbering scheme, update scenario D104 with BTL v3
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43553/38154
|
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@Dr15Jones, @jfernan2, @mandrenguyen, @srimanob, @cmsbuild, @bsunanda, @subirsarkar, @makortel, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 27634.0 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c99e72/36440/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+Upgrade |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR adds a new BTL scenario V3 on top of the just integrated MTD scenario I17, added in #43407 . This new configuration, developed by @pauris123 , differs from V2 for the crystal thickness, set everywhere to 3.75 mm, as it will be in reality (purchase order ongoing). This is the opportunity to drop the crystal thickness from the geometry construction, and have 6 equal readout units along z.
The numbering scheme for the time being is just adapted to the existing
BTLDetId, creating an effective crystal thickness index, so as to postpone the major update to the moment in which the BTL V1 can be finally dropped, allowing us to optimize the bit fields structure for a final configuration.PR validation:
All basic geometry checks (when geometry scenario is adapted) look reasonable, and a complete workflow runs. No overlap is detected at ideal geometry level, and visual inspection in fireworks appears ok.