introduce `requireL3MuonTrajectorySeed` data member in `HLTMuonL3PreFilter` and use it do define whether or not to consume certain products #43549

mmusich · 2023-12-12T14:32:32Z

PR description:

Title says it all, follows-up from suggestion at #43517 (comment).

One possibility to improve the implementation of HLTMuonL3PreFilter is to add a boolean parameter to the plugin (say, requireL3MuonTrajectorySeed) which, if true, would make the plugin throw an exception if this cast fails. In the constructor, one could then call consumes on InputLinks, L1CandTag and inputMuonCollection only if requireL3MuonTrajectorySeed == false (something like this (random example)). The parameter requireL3MuonTrajectorySeed would be false by default, but in the case of hltL3fDimuonL1f0L2NVf16L3NoFiltersNoVtxFiltered43 (and maybe other modules), we could set it to true.

This implements the first part (which to allow disentangling the consumes when they are not needed). A customize function in customizeHLTforCMSSW is added such that the newly added boolean is flipped for a list of selected modules in HLT menu.

PR validation:

#!/bin/bash

hltGetConfiguration /dev/CMSSW_13_3_0/GRun \
   --globaltag auto:phase1_2024_realistic \
   --mc \
   --unprescale \
   --output minimal \
   --max-events 100 \
   --input /store/relval/CMSSW_13_3_0_pre4/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/133X_mcRun3_2023_realistic_v1_Standard_13_3_0_pre4-v1/2590000/4c47f6d7-9938-4c87-b795-ece3aa6d3d22.root \
   --eras Run3 --l1-emulator FullMC --l1 L1Menu_Collisions2023_v1_3_0_xml \
   > hlt.py
cat <<@EOF >> hlt.py
process.options.numberOfThreads = 1
process.options.numberOfStreams = 0
@EOF
cmsRun hlt.py &> hlt.log

runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

cmsbuild · 2023-12-12T14:39:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43549/38146

This PR adds an extra 16KB to repository

cmsbuild · 2023-12-12T14:39:39Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

HLTrigger/Muon (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@andrea21z, @missirol, @cericeci, @silviodonato, @abbiendi, @jhgoh, @CeliaFernandez, @trocino, @HuguesBrun, @Fedespring, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-12-12T16:22:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43549/38152

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454, ECAL unpacker and ECAL multifit algorithm migration to alpaka #43257

cmsbuild · 2023-12-12T16:22:26Z

Pull request #43549 was updated. @cmsbuild, @mmusich, @Martin-Grunewald can you please check and sign again.

mmusich · 2023-12-12T18:35:58Z

@cmsbuild, please test

cmsbuild · 2023-12-12T20:17:46Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d72dac/36443/summary.html
COMMIT: daa9e9d
CMSSW: CMSSW_14_0_X_2023-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43549/36443/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

141.044

----- Begin Fatal Exception 12-Dec-2023 20:25:41 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing  Event run: 369978 lumi: 219 event: 197869656 stream: 0
   [1] Running path 'HLT_CascadeMu100_v9'
   [2] Calling method for module HLTMuonL3PreFilter/'hltL3fL1sMu22Or25L1f0L2f10QL3Filtered100Q'
Exception Message:
A get using a EDGetToken with the C++ type 'std::vector<reco::Muon>' was made using an uninitialized token.
 Please check that the variable is being initialized from a 'consumes' call.
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 12-Dec-2023 20:36:28 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'HLT_CascadeMu100_v7'
   [2] Calling method for module HLTMuonL3PreFilter/'hltL3fL1sMu22Or25L1f0L2f10QL3Filtered100Q'
Exception Message:
A get using a EDGetToken with the C++ type 'std::vector<reco::Muon>' was made using an uninitialized token.
 Please check that the variable is being initialized from a 'consumes' call.
----- End Fatal Exception -------------------------------------------------

12434.7

----- Begin Fatal Exception 12-Dec-2023 20:36:40 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'HLT_CascadeMu100_v7'
   [2] Calling method for module HLTMuonL3PreFilter/'hltL3fL1sMu22Or25L1f0L2f10QL3Filtered100Q'
Exception Message:
A get using a EDGetToken with the C++ type 'std::vector<reco::Muon>' was made using an uninitialized token.
 Please check that the variable is being initialized from a 'consumes' call.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

12634.0

RelVals-INPUT

141.001141.001_RunMuon2023B/step2_RunMuon2023B.log
141.031141.031_RunMuon2023C/step2_RunMuon2023C.log
141.041141.041_RunMuon2023D/step2_RunMuon2023D.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 12-Dec-2023 20:25:42 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 10 stream: 0
   [1] Running path 'HLT_CascadeMu100_v9'
   [2] Calling method for module HLTMuonL3PreFilter/'hltL3fL1sMu22Or25L1f0L2f10QL3Filtered100Q'
Exception Message:
A get using a EDGetToken with the C++ type 'std::vector<reco::Muon>' was made using an uninitialized token.
 Please check that the variable is being initialized from a 'consumes' call.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 12-Dec-2023 20:27:49 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 2
   [1] Running path 'HLT_CascadeMu100_v9'
   [2] Calling method for module HLTMuonL3PreFilter/'hltL3fL1sMu22Or25L1f0L2f10QL3Filtered100Q'
Exception Message:
A get using a EDGetToken with the C++ type 'std::vector<reco::Muon>' was made using an uninitialized token.
 Please check that the variable is being initialized from a 'consumes' call.
----- End Fatal Exception -------------------------------------------------

…er and use it do define whether or not to consume certain products

…dTag, InputLinks and inputMuonCollection are empty the HLTMuonL3PreFilter is configured such that the flag requireL3MuonTrajectorySeed is true

cmsbuild · 2023-12-12T21:07:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43549/38157

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454, ECAL unpacker and ECAL multifit algorithm migration to alpaka #43257

cmsbuild · 2023-12-12T21:08:26Z

Pull request #43549 was updated. @cmsbuild, @Martin-Grunewald, @mmusich can you please check and sign again.

mmusich · 2023-12-13T01:35:21Z

@cmsbuild, please test

cmsbuild · 2023-12-13T04:31:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d72dac/36450/summary.html
COMMIT: 52d83d7
CMSSW: CMSSW_14_0_X_2023-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43549/36450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3429858
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3429830
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2023-12-14T08:05:14Z

+hlt

cmsbuild · 2023-12-14T08:05:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-12-14T13:15:43Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Dec 12, 2023

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 12, 2023

mmusich mentioned this pull request Dec 12, 2023

Unrunnable schedule exception on a small subset of HLT menu #43517

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2023

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2023

cmsbuild added tests-started and removed tests-pending labels Dec 12, 2023

cmsbuild added tests-rejected and removed tests-started labels Dec 12, 2023

mmusich added 2 commits December 12, 2023 21:58

introduce requireL3MuonTrajectorySeed data member in HLTMuonL3PreFilt…

976e7a8

…er and use it do define whether or not to consume certain products

add a customization function to enforce that if all 3 InputTags L1Can…

52d83d7

…dTag, InputLinks and inputMuonCollection are empty the HLTMuonL3PreFilter is configured such that the flag requireL3MuonTrajectorySeed is true

mmusich force-pushed the mm_dev_prefilter_L3MuonTrajChecks branch from daa9e9d to 52d83d7 Compare December 12, 2023 20:59

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Dec 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2023

cmsbuild added tests-started and removed tests-pending labels Dec 13, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 13, 2023

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Dec 14, 2023

cmsbuild mentioned this pull request Dec 14, 2023

ECAL unpacker and ECAL multifit algorithm migration to alpaka #43257

Merged

cmsbuild added orp-approved and removed orp-pending labels Dec 14, 2023

cmsbuild merged commit 70200fc into cms-sw:master Dec 14, 2023

mmusich deleted the mm_dev_prefilter_L3MuonTrajChecks branch December 14, 2023 13:16

cmsbuild mentioned this pull request Dec 15, 2023

[Do not merge] testing bot #43568

Closed

introduce requireL3MuonTrajectorySeed data member in HLTMuonL3PreFilter and use it do define whether or not to consume certain products #43549

introduce requireL3MuonTrajectorySeed data member in HLTMuonL3PreFilter and use it do define whether or not to consume certain products #43549

Uh oh!

Conversation

mmusich commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Dec 12, 2023

Uh oh!

cmsbuild commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 12, 2023

Uh oh!

cmsbuild commented Dec 12, 2023

Uh oh!

mmusich commented Dec 12, 2023

Uh oh!

cmsbuild commented Dec 12, 2023

RelVals

RelVals-INPUT

AddOn Tests

Uh oh!

cmsbuild commented Dec 12, 2023

Uh oh!

cmsbuild commented Dec 12, 2023

Uh oh!

mmusich commented Dec 13, 2023

Uh oh!

cmsbuild commented Dec 13, 2023

Comparison Summary

Uh oh!

mmusich commented Dec 14, 2023

Uh oh!

cmsbuild commented Dec 14, 2023

Uh oh!

rappoccio commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

introduce `requireL3MuonTrajectorySeed` data member in `HLTMuonL3PreFilter` and use it do define whether or not to consume certain products #43549

introduce `requireL3MuonTrajectorySeed` data member in `HLTMuonL3PreFilter` and use it do define whether or not to consume certain products #43549

mmusich commented Dec 12, 2023 •

edited

Loading

cmsbuild commented Dec 12, 2023 •

edited

Loading