Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 24, 2023

PR description:

Since when #38304 is merged, the old "all-in-one" tracker alignment offline validation meta-tool is orphaned, and the corresponding files remaining in cmssw serve no purpose.
I remove them here (PR still as a draft, so that Tk alignment people @TomasKello @henriettepetersen have a chance to have a look).

PR validation:

scram b runtests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43386/37880

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@perrotta, @saumyaphor4252, @cmsbuild, @consuegs can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @yuanchao, @adewit, @rsreds, @tlampen this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 24, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e161c0/36053/summary.html
COMMIT: 624f32e
CMSSW: CMSSW_14_0_X_2023-11-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43386/36053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

@mmusich you removed the "draft" flag: should we assume that that the Tk Alignment people has greenlighted these file removals, then? If so, this PR can be signed, as evidently no workflow is affected by it.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2023

Tk Alignment people has greenlighted these file removals

It was discussed privately in a mattermost thread indeed.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants