-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[TkAl] remove "old" all-in-one metatool from cmssw #43386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TkAl] remove "old" all-in-one metatool from cmssw #43386
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43386/37880
|
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @saumyaphor4252, @cmsbuild, @consuegs can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e161c0/36053/summary.html Comparison SummarySummary:
|
|
@mmusich you removed the "draft" flag: should we assume that that the Tk Alignment people has greenlighted these file removals, then? If so, this PR can be signed, as evidently no workflow is affected by it. |
It was discussed privately in a mattermost thread indeed. |
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Since when #38304 is merged, the old "all-in-one" tracker alignment offline validation meta-tool is orphaned, and the corresponding files remaining in
cmsswserve no purpose.I remove them here (
PR still as a draft, so that Tk alignment people @TomasKello @henriettepetersen have a chance to have a look).PR validation:
scram b runtestsruns fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A